[Twisted-Python] Bloat (was Re: [Twisted-commits] DependentMultiService - chained start/stop of services in a sensible order)

[Glyph Lefkowitz]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday, April 13, 2003, at 09:54 PM, Bob Ippolito wrote:

> DependentMultiService is a very crude basis for such a mechanism, 
> because I don't need that kind of functionality yet.  However, it does 
> provide a pretty decent base class for a future Twisted 
> "SystemStarter" equivalent... which we *should* want to have someday.

YAGNI.

More specifically - maybe we will eventually need such a thing.  In the 
process of building a real "SystemStarter" equivalent, however, we may 
find that DependentMultiService actually isn't that useful, and we 
instead want to use some other intermediary dependency management 
strategy.

In a more optimistic case, we're merely maintaining an interface to an 
implementation detail that people shouldn't be using.  In a worse case, 
we have another twisted.python.observable on our hands - dead code that 
one or two things are using because we haven't had time to update them 
to use TwistedStarter instead.

In fact, I think that TwistedStarter sounds like a good idea - it 
provides a high-level interface to some functionality that may be 
tricky to implement correctly.  If you would go all the way and 
implement that I would probably be less unhappy than if this stayed in 
:-).

However, this is just an advice, not an "MDFL pronouncement" - the 
final call on that module is Itamar's, and if he's not going to stop 
you checking it in, then I'll concede.  I was mainly using this as an 
example, not as a particularly egregious thing that really needs to go. 
  I want Twisted developers to consider things like continuing 
maintenance before checking things in.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (Darwin)

iD8DBQE+mpiMvVGR4uSOE2wRAo9RAKCRICLQu0IJPhiRrr1X8Y9bM/B5AwCfVBur
RFYJtMNc7n2SkS2VX44Zv+U=
=iLtN
-----END PGP SIGNATURE-----