[Twisted-Python] twisted.news cleanups and tests

Peter Hansen peter at engcorp.com
Sun Apr 13 21:59:30 EDT 2003


Jp Calderone wrote:
> 
>     In the test cases, you also used assert_() (but just once, I assume it
> was an oversight), which shouldn't be access directly by tests cases, so I
> changed this to a failUnless().  

Jp, I realize Twisted unittest is either slightly older than the standard,
or perhaps slightly evolved from it, but I'm not sure why you think 
assert_() shouldn't be used directly by TestCases.  According at least to 
http://www.python.org/doc/current/lib/testcase-objects.html it's merely
a synonym for failUnless(), as all the other assertXxxx() variants are 
synonyms of their respective failXxxxx() methods.  I think it is intended
to be a perfectly valid exposed method.

-Peter




More information about the Twisted-Python mailing list