[Twisted-Python] [PATCH] domhelpers.py

[Donovan Preston]

On Tuesday, July 23, 2002, at 04:43 PM, Ken Kennedy wrote:

> I've been working on porting the blog example to the new 0.19
> DOMTemplate format, as an opportunity to play with some Twisted
> code. In doing so, I think I've found this big, bad single-line, 5
> character patch for domhelpers.py. Patch is attached. AFAICT, this is
> correct; I'll admit, though, I'm a python journeyman at best, so I may
> have mis-fixed.

Yes, indeed, that's a typo, and your fix is correct. Obviously that bug 
was left over from a refactoring of substitute from a method to a 
function. Really shows me I need to write more unit tests.

> Also, I should be finished with the blog example in a day or two...is
> there interest in replacing the old-style one? If so, where should I
> send the code? After finishing the straight port, I'm going to look at
> implementing some authorization via Twisted Cred; I'm trying to decide
> between using Zope and Twisted for some future projects, so I'm
> playing with comparable functionalities...I have to admit, Twisted is
> pretty dang cool!

Wow. I wrote both Blog and DOMTemplate, and I had been planning on 
refactoring Blog sometime soon, but hadn't gotten around to it. I didn't 
think anybody cared enough! *sniff* Thank you. :-)

Donovan