[Twisted-Python] Re: internet passport.py,1.15,1.16

Kevin Turner acapnotic at twistedmatrix.com
Mon Nov 5 14:09:04 MST 2001


On Mon, Nov 05, 2001 at 08:24:53AM -0600, Glyph Lefkowitz wrote:
> Modified Files:
> 	passport.py 
> Log Message:
> * small API change to internet.passport; Perspectives are now only
>   attached to the service when they are added to it.

Um, okay.  But why?  Your commit just added an extra line to every place
in the codebase which created a Perspective, without making that code
any more expressive.  If Perspectives in fact only exist to provide a
perspective to a specific service, in what situation would you create
Perspectives without having a Service to pass to the constructor?

Even given the existance of such situations, Service.createPerspective
is decidedly *not* one of them.  Why does a Perspective returned from
a Service method -- which has been added to the Service's list of
perspectives -- not have its service attribute set?

-- 
The moon is waning gibbous, 80.7% illuminated, 19.0 days old.





More information about the Twisted-Python mailing list