Changes between Version 8 and Version 9 of CommitterCheckList

Timestamp:

01/20/2012 06:27:55 PM (16 months ago)

Author:

exarkun

Comment:

Try to split out some things that are of a non-technical nature for the purposes of highlighting them

CommitterCheckList

@@ -1 @@
-This is a list of things that developers with commit access to the Twisted source repository should know:
+These are things that developers with commit access to the Twisted source repository should know.  The first list is of policy items (i.e., things you should or should not try to do).
+
+  1. All development is done in branches.
+  1. All code committed to trunk must go through the ReviewProcess.
+  1. trunk commit messages must follow the format described on ReviewProcess so that various pieces of automation can work.
+  1. If you check in something that breaks [http://buildbot.twistedmatrix.com/boxes-supported?branch=trunk&num_builds=20 trunk], revert it
+  1. Everything you check in to SVN is licensed under [browser:trunk/LICENSE Twisted's license]
+  1. Be in the IRC channel, at least when you're going to be committing to trunk (don't feel bad about avoiding the distraction when you're trying to get stuff done though).
+  1. Have fun, but not too much.
+
+This second list includes various technical details about how you might go about doing Twisted development (and has overlap for organizational purposes):
 
   1. SVN access is via `svn+ssh` scheme
@@ -28 +38 @@
     1. `force-builds.py` prints a link to a results page; mention it in the ticket as a link with the text "Build results" like this: `[url-goes-here Build Results]`
     1. There are certain unit-tests on certain builders that are known to fail intermittently. There's no official list of such tests, but you can look at [http://buildbot.twistedmatrix.com/boxes-supported?branch=trunk&num_builds=20 the history of trunk builds] for a particular builder to see if a particular failure shows up a lot. If you're sure that a given build failure is intermittent and not caused by the changes in your branch, you can still merge.
-  1. Be in the IRC channel, at least when you're going to be committing to trunk (don't feel bad about avoiding the distraction when you're trying to get stuff done though).
-  1. Everything you check in to SVN is licensed under [browser:trunk/LICENSE Twisted's license]
-  1. Have fun, but not too much.
 
 Other documents that overlap and supplement this information include: