Ticket #971 (new enhancement )

Opened 4 years ago

Last modified 4 years ago

cddb client protocol

Reported by: rhymes Assigned to: itamarst
Type: enhancement Priority: normal
Milestone: Component:
Keywords: Cc: itamarst, teratorn, rhymes
Branch: Author:
Launchpad Bug:

Attachments

cddbp.py (11.3 kB) - added by rhymes 4 years ago.
test_cddbp.py (10.5 kB) - added by rhymes 4 years ago.

Change History

  2005-04-09 00:19:10+00:00 changed by rhymes

  • attachment cddbp.py added

  2005-04-09 00:19:10+00:00 changed by rhymes

cddb client protocol implementation

  2005-04-09 00:19:33+00:00 changed by rhymes

  • attachment test_cddbp.py added

  2005-04-12 01:16:10+00:00 changed by teratorn

I had a quick read through your code and it looks pretty good. The doc strings
are refreshingly well done :)
One question I have right now,
Have you considered writing a client interface that uses deferreds?
I understand that this is just a protocol implementation, but to
be most useful, users are going to want to integrate with their
existing deferred-using code.
I suggest you rename the CDDBPClient to the more verbose name
CDDBClientProtocol. Then provide a high-level CDDBClient which one would use to
connect to a cddb server and run queries. Appropriate methods should return
deferrds, and the implementation would gather the results as they are available
and fire the deferred once a full response has been received.
What do you think?
Anyway, it's late and I'm heading to bed.. maybe I'll think of something else
tomorrow :)
Note: See TracTickets for help on using tickets.