Opened 9 years ago

Closed 4 years ago

#971 enhancement closed wontfix (wontfix)

cddb client protocol

Reported by: rhymes Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: itamarst, teratorn, rhymes, thomas@… Branch:
Author: Launchpad Bug:

Description


Attachments (2)

cddbp.py (11.3 KB) - added by rhymes 9 years ago.
test_cddbp.py (10.5 KB) - added by rhymes 9 years ago.

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by rhymes

comment:1 Changed 9 years ago by rhymes

cddb client protocol implementation

Changed 9 years ago by rhymes

comment:2 Changed 9 years ago by teratorn

I had a quick read through your code and it looks pretty good. The doc strings 
are refreshingly well done :)

One question I have right now,

Have you considered writing a client interface that uses deferreds?
I understand that this is just a protocol implementation, but to
be most useful, users are going to want to integrate with their
existing deferred-using code.

I suggest you rename the CDDBPClient to the more verbose name 
CDDBClientProtocol. Then provide a high-level CDDBClient which one would use to 
connect to a cddb server and run queries. Appropriate methods should return 
deferrds, and the implementation would gather the results as they are available 
and fire the deferred once a full response has been received.

What do you think?

Anyway, it's late and I'm heading to bed.. maybe I'll think of something else 
tomorrow :)

comment:3 Changed 4 years ago by thomasvs

  • Cc thomas@… added
  • Component set to conch

comment:4 Changed 4 years ago by thomasvs

didn't mean to change component to conch, trac did that automatically since it has to be from the dropdown.

comment:5 Changed 4 years ago by itamar

  • Component changed from conch to core
  • Resolution set to wontfix
  • Status changed from new to closed

I think this is a specialized enough protocol that we're not going to include it in Twisted proper. A standalone package ("txCddb", say) is probably the way to go.

comment:6 Changed 3 years ago by <automation>

  • Owner itamarst deleted
Note: See TracTickets for help on using tickets.