Opened 4 weeks ago

Last modified 2 weeks ago

#9382 defect new

twisted.trial._dist.test.test_disttrial leaks file descriptors

Reported by: mark williams Owned by:
Priority: normal Milestone: Eliminate ResourceWarnings
Component: trial Keywords:
Cc: Branch:


These tests leave log files open because they don't always call LocalWorker.connectionLost. The resulting ResourceWarnings cause tests that make assertions about generated warnings to fail, such as twisted.trial.test.test_assertions.CallDeprecatedTests.test_nestedDeprecation.

These tests should instead close their files.

Change History (3)

comment:1 Changed 4 weeks ago by mark williams

Milestone: Eliminate ResourceWarnings

comment:2 Changed 4 weeks ago by mark williams

Keywords: review added

This actually fixes everything in twisted.trial._dist.test.

comment:3 Changed 2 weeks ago by Craig Rodrigues

Keywords: review removed
Note: See TracTickets for help on using tickets.