Opened 3 weeks ago

Last modified 11 days ago

#9338 enhancement new

Add `twist' to list of commands we provide shell tab-completion for

Reported by: teratorn Owned by:
Priority: lowest Milestone:
Component: core Keywords: review easy
Cc: Branch:
Author:

Description

We should provide shell-tab completion for `twist' just like the other Twisted commands. Right now that only means zsh.

This is accomplished by adding "twist" to the #compdef list in the file src/twisted/python/twisted-completion.zsh

An older version of this zsh completion stub is shipped in zsh, and is the primary means by which zsh "knows" how to complete Twisted commands out of the box.

Updating the list of Twisted commands necessarily means pushing a new version of this stub upstream to zsh.

The last attempt to get a new stub in zsh didn't go so well. http://www.zsh.org/mla/workers/2013/msg00077.html

But I think it's worth another shot - if zsh folks don't provide us with a standard, structured way to provide dynamic completion functionality, then I don't think they should complain about us continuing to do things the way they have been done and are currently still done (by eval'ing a zsh completion function provided by Twisted on stdout)

Change History (3)

comment:1 Changed 3 weeks ago by Glyph

By all means, let's do it!

(It would be nice to get bash completion too, at some point.)

comment:2 Changed 2 weeks ago by teratorn

Keywords: review added

comment:3 Changed 11 days ago by teratorn

Keywords: easy added

Added easy keyword because this is a simple change. But note someone still needs to poke the zsh mailing list after we update our tree..

Note: See TracTickets for help on using tickets.