Opened 17 months ago

Closed 17 months ago

Last modified 15 months ago

#8643 enhancement closed duplicate (duplicate)

Use the console_script installed version of trial when running coverage

Reported by: Craig Rodrigues Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: 8643-rodrigc-tox-trial-win
branch-diff, diff-cov, branch-cov, buildbot
Author:

Description

In tox.ini, there is this:

    coverage-posix: coverage run -p --rcfile={toxinidir}/.coveragerc {envbindir}/trial --reactor={env:TWISTED_REACTOR:default} --reporter={env:TRIAL_REPORTER:verbose} {posargs:twisted}
    # FIXME: https://twistedmatrix.com/trac/ticket/8611
    # {toxinidir}/bin/trial works for Python 2.7 but not for Python 3.4
    coverage-windows: coverage run -p --rcfile={toxinidir}/.coveragerc {toxinidir}/bin/trial --reactor={env:TWISTED_REACTOR:default} --reporter={env:TRIAL_REPORTER:verbose} {posargs:twisted}

We should use the console_script of trial installed into the tox virtual environment.

Windows is slightly different. For the trial console script, it installs two files:

{envbindir}/trial.exe {envbindir}/trial-script.py

We want to run coverage on trial-script.py

Change History (5)

comment:1 Changed 17 months ago by Craig Rodrigues

Keywords: review added

comment:2 Changed 17 months ago by Craig Rodrigues

Branch: 8643-rodrigc-tox-trial-win

comment:3 Changed 17 months ago by Craig Rodrigues

Closing in favor of 8712

comment:4 Changed 17 months ago by Craig Rodrigues

Resolution: duplicate
Status: newclosed

comment:5 Changed 15 months ago by hawkowl

Keywords: review removed

[mass edit] Removing review from closed tickets.

Note: See TracTickets for help on using tickets.