#8450 enhancement closed duplicate (duplicate)

Remove use of types module constants in twisted/conch

Reported by: Craig Rodrigues Owned by: Craig Rodrigues
Priority: normal Milestone: Python-3.x
Component: core Keywords:
Cc: Branch:
Author:

Description

The *types* module constants have been removed in Python 3. For example using *types.TupleType* in Python 3 will give an *AttributeError*

These constants should be removed and replaced with the primitive type instead. See:

http://www.diveintopython3.net/porting-code-to-python-3-with-2to3.html#types

Change History (3)

comment:1 Changed 18 months ago by Craig Rodrigues

Keywords: review added

comment:2 Changed 18 months ago by Adi Roiban

Keywords: review removed
Owner: set to Craig Rodrigues

These changes look useless to me... and somehow wrong. Sorry.

They are only changing the docstrings and we should not document using function calls.

For the NoneType documentation, I think that we agreed to just use C{None} as everybody should know that the type of the None if NoneType ... and we don't need to fill the documentation with link to the NoneType declaration.

I have also checked #8456 and it has the same changes.

If you want these changes made, please just use C{None} and submit all changes into a single ticket.

Thanks!

comment:3 Changed 18 months ago by Craig Rodrigues

Resolution: duplicate
Status: newclosed

Consolidating with 8456

Note: See TracTickets for help on using tickets.