Opened 2 years ago

Closed 2 years ago

#8099 task closed fixed (fixed)

Port twisted.internet.serialport to Python 3

Reported by: Thijs Triemstra Owned by: Thijs Triemstra
Priority: normal Milestone: Python-3.x
Component: core Keywords:
Cc: Thijs Triemstra Branch: branches/serialport-py3-8099
branch-diff, diff-cov, branch-cov, buildbot
Author: adiroiban

Description

Was playing with the txgsm project on Python 3.4, which uses twisted.internet.serialport, and noticed it didn't install twisted/internet/serialport.py and twisted/internet/_posixserialport.py in my virtualenv.

This stackoverflow post describes the same problem, but the solution is simple, port it to python 3 and include it in twisted.python.dist3 so it gets shipped.

Attachments (1)

8099.patch (2.7 KB) - added by Thijs Triemstra 2 years ago.

Download all attachments as: .zip

Change History (8)

Changed 2 years ago by Thijs Triemstra

Attachment: 8099.patch added

comment:1 Changed 2 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Keywords: review added

Please review.

comment:2 Changed 2 years ago by Adi Roiban

Author: adiroiban
Branch: branches/serialport-py3-8099

(In [46115]) Branching to serialport-py3-8099.

comment:3 Changed 2 years ago by Adi Roiban

Keywords: review removed
Owner: set to Thijs Triemstra

Many thanks for the patch!

The patch also needs a news file fragment so that we have this new feature mentioned in the release notes.

I have also added the win32 serial code to the list of ported code so that it will be installed on windows.

I have sent the patch to buildbot.

If all is ok, will merge.

I have added the news fragment. Please check that it make sense.

Thanks!

comment:4 Changed 2 years ago by Adi Roiban

While tests are green (most of them) there are a few problems with twisted/internet/test/test_serialport.py

The tests are pretty thin and on top of that they are not executed on our python 3 builders.

Twisted is not yet ported on Windows with Python3.

I will check with the other Twisted developers and see if we can get pyserial installed/updated our the testing infrastructure.

I would like to have the test run on Python3 before merging this :)

Thanks!

comment:5 Changed 2 years ago by Thijs Triemstra

Owner: changed from Thijs Triemstra to Adi Roiban

Thanks for the update adiroiban. I realize there's not a lot of tests but everything seems to work fine on posix. Any news on the pyserial installations? I suppose I'll assign it back to you.

comment:6 Changed 2 years ago by Adi Roiban

Owner: changed from Adi Roiban to Thijs Triemstra

I have installed pyserial on our buildslaves and the single test looks good so far.

Will merge once all tests are done.

Thanks!

comment:7 Changed 2 years ago by Adi Roiban

Resolution: fixed
Status: newclosed

(In [46227]) Merge serialport-py3-8099: twisted.internet.serialport port on Python 3.

Author: thijs Reviewer: adiroiban Fixes: #8099

Note: See TracTickets for help on using tickets.