Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#8006 enhancement closed duplicate (duplicate)

ValueError: Unknown endpoint type: 'tls'

Reported by: hawkowl Owned by: hawkowl
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/what-is-ssl-8006
branch-diff, diff-cov, branch-cov, buildbot
Author: hawkowl

Description

As we all know, there Is No SSL, so Twisted should instead talk about TLS instead of SSL.

Change History (8)

comment:1 Changed 2 years ago by hawkowl

Author: hawkowl
Branch: branches/what-is-ssl-8006

(In [45547]) Branching to what-is-ssl-8006.

comment:2 Changed 2 years ago by hawkowl

Keywords: review added

This moves the SSL4 endpoints to be TLS4, deprecates the old accesses, and allows tls: to be used in strports.

It also combs through the documentation and updates the language to refer to TLS instead of SSL.

https://github.com/twisted/twisted/compare/trunk...what-is-ssl-8006?w=1 is a much nicer view (whitespace changes?).

comment:3 Changed 2 years ago by Jeremy Thurgood

Minor nit: In twisted/internet/test/test_endpoints.py, there are two docstrings that claim to "Create an L{TLS4ClientEndpoint}". The indefinite article should change from "an" to "a".

Will renaming ssl.rst to tls.rst (and the related examples, etc.) break any links to docs?

comment:4 Changed 2 years ago by habnabit

I'm not a fan of this. This just makes tls: do exactly the same thing that ssl: did before. #5642 I feel is a superior option: the tls: endpoint type uses HostnameEndpoint, so it gets all of the benefits that offers.

Also, there's no deprecation warning emitted when the ssl: endpoint is used, as far as I can tell.

comment:5 Changed 2 years ago by Adi Roiban

Keywords: review removed
Owner: set to hawkowl

Hi,

Thanks for working on this.

There is a SSL related failing test on ubuntu15.04-py2.7-nomodules and windows7-64-py2.7


This patch contains many formatting changes which are not related to the SSL wipeout.

I suggest to move them in a separate patch so that they could be accepted right away.


I am ok with adding the tls prefix and the TLS classes.

Why the rush to remove all records of SSL ? :)

Since the SSL endpoint does not change any functionality, but only it's name, why deprecate it?

I feel that we add extra work to Twisted users without providing them with any new features.


Please check the failing tests.

Since the TLS/SSL renameing/deprecations might turn out to be controversial, I think that we can merge the non renaming changes in a separate branch.

Thanks!

comment:6 in reply to:  4 Changed 2 years ago by Glyph

Resolution: duplicate
Status: newclosed

Replying to habnabit:

I'm not a fan of this. This just makes tls: do exactly the same thing that ssl: did before. #5642 I feel is a superior option: the tls: endpoint type uses HostnameEndpoint, so it gets all of the benefits that offers.

Also, there's no deprecation warning emitted when the ssl: endpoint is used, as far as I can tell.

Very much this. In fact, I'm going to close this as a duplicate, since these endpoints were intentionally named poorly, specifically so that the modern "tls" namespace would not be consumed by old, bad hard-coded TCPv4 endpoints. I'm sorry that that decision was not communicated clearly to maintainers.

comment:7 Changed 2 years ago by Adi Roiban

We can still extract the non SSL->TLS rename changes from this branch and merge them as a separate ticket. What do you say? ... in this way we can recover some work with otherwise would be lost.

comment:8 in reply to:  7 Changed 2 years ago by Glyph

Replying to adiroiban:

We can still extract the non SSL->TLS rename changes from this branch and merge them as a separate ticket. What do you say? ... in this way we can recover some work with otherwise would be lost.

Sure, that sounds great. I am closing the ticket because the stated goal should not be accomplished (making existing SSL endpoints called "TLS") not because none of the code in the branch is worthwhile.

Note: See TracTickets for help on using tickets.