Opened 3 years ago

Closed 3 years ago

#7834 enhancement closed fixed (fixed)

Port twisted.cred.checkers to Python 3

Reported by: hawkowl Owned by: hawkowl
Priority: normal Milestone: Python-3.x
Component: core Keywords:
Cc: Einar Fløystad Dørum Branch: branches/twcred-py3-7834-3
branch-diff, diff-cov, branch-cov, buildbot
Author: hawkowl

Description


Change History (9)

comment:1 Changed 3 years ago by hawkowl

Author: hawkowl
Branch: branches/twcred-py3-7834

(In [44293]) Branching to twcred-py3-7834.

comment:2 Changed 3 years ago by hawkowl

Ready for review when #6176 lands.

comment:3 Changed 3 years ago by hawkowl

Branch: branches/twcred-py3-7834branches/twcred-py3-7834-2

(In [44732]) Branching to twcred-py3-7834-2.

comment:4 Changed 3 years ago by hawkowl

Keywords: review added
Owner: hawkowl deleted

Builders spun, green looking, please review.

I cleaned up some tests as well, and added some docstrings.

comment:5 Changed 3 years ago by Einar Fløystad Dørum

Cc: Einar Fløystad Dørum added

comment:6 Changed 3 years ago by Adi Roiban

Keywords: review removed
Owner: set to hawkowl

Changes look good. Thanks!

Do we still need to import PAM ?


I find this hard to read this as it hide the actual call to login.... but the new code is better than the old one :)

login = self.successResultOf(self.portal.login(
    DerivedCredentials(b"bob", b"hello"), self, ITestable))

maybe this is cleaner

deferred = self.portal.login(
    DerivedCredentials(b"bob", b"hello"), self, ITestable)

iface, impl, logout = self.successResultOf(deferred)


Please check the PAM part and merge after the branch is updated with trunk and PAM is no longer used.

Thanks!

comment:7 Changed 3 years ago by hawkowl

Branch: branches/twcred-py3-7834-2branches/twcred-py3-7834-3

(In [44894]) Branching to twcred-py3-7834-3.

comment:8 Changed 3 years ago by hawkowl

(In [44895]) Merge forward, refs #7834

comment:9 Changed 3 years ago by hawkowl

Resolution: fixed
Status: newclosed

(In [44898]) Merge twcred-py3-7834-3: Port twisted.cred.checkers to Python 3

Author: hawkowl Reviewer: adiroiban Fixes: #7834

Note: See TracTickets for help on using tickets.