Opened 3 years ago

Closed 2 years ago

#7817 enhancement closed fixed (fixed)

Port twisted.application.internet on py3

Reported by: Adi Roiban Owned by: hawkowl
Priority: normal Milestone: Python-3.x
Component: core Keywords:
Cc: Branch: branches/twapp-internet-py3-7817
branch-diff, diff-cov, branch-cov, buildbot
Author: hawkowl

Description


Change History (4)

comment:1 Changed 2 years ago by hawkowl

Author: hawkowl
Branch: branches/twapp-internet-py3-7817

(In [45158]) Branching to twapp-internet-py3-7817.

comment:2 Changed 2 years ago by hawkowl

Keywords: review added

This is an initial port; the missing coverage is in twisted.test.test_application, which needs twisted.application.app to be ported, which will be put up for review right after this one is merged.

Builders are spun and looking good, please review.

comment:3 Changed 2 years ago by Adi Roiban

Keywords: review removed
Owner: set to hawkowl

Changes look good.

Why have you removed test_applicationComponentsArePersistable ?

Please check my commend and merge.

Thanks!

comment:4 Changed 2 years ago by hawkowl

Resolution: fixed
Status: newclosed

(In [45163]) Merge twapp-internet-py3-7817: Port twisted.application.internet to Python 3

Author: hawkowl Reviewer: adiroiban Fixes: #7817

Note: See TracTickets for help on using tickets.