Ticket #702 (new defect )

Opened 4 years ago

Last modified 3 months ago

MSN Protocol bugs (with patches & unit tests)

Reported by: delx Assigned to: exarkun
Type: defect Priority: normal
Milestone: Component: words
Keywords: words Cc: z3p, delx, thijs
Branch: branches/msn-not-etc-702 Author: exarkun
Launchpad Bug:

Attachments

msnfixes.patch (5.8 kB) - added by delx 4 years ago.
msnfixes.2.patch (5.8 kB) - added by delx 4 years ago.

Change History

  2004-09-05 14:51:59+00:00 changed by delx

  • attachment msnfixes.patch added

  2004-09-05 14:52:00+00:00 changed by delx 

Attached is a patch that fixes quite a few things in Twisted MSN support.
* An exception will no longer be thrown on an incoming NOT (MSN Alerts)
message.
* A fix for occasional exceptions on receiving messages.
* Fix receiving of contact status and friendly name changes to be safer, and
to actually update the factory =P (friendly name updates didn't occur
previously)
* Removed a stray print statement
The unit test added is for the first case. The other ones I didn't really think
were appropriate to have unit tests.

  2004-09-05 15:47:38+00:00 changed by delx

  • attachment msnfixes.2.patch added

  2004-09-05 15:47:38+00:00 changed by delx 

Oops. Ignore the previous patch.

  2006-12-05 05:15:02+00:00 changed by exarkun

  • owner changed from z3p to exarkun
  • component set to words

  2008-08-05 22:09:04+00:00 changed by thijs

  • cc changed from z3p, delx to z3p, delx, thijs
  • keywords changed from words to words, review
  • owner deleted
  • branch deleted
  • author deleted

this one needs a review.

  2008-08-14 13:24:53+00:00 changed by exarkun

  • branch set to branches/msn-not-etc-702
  • author set to exarkun

(In [24577]) Branching to 'msn-not-etc-702'

  2008-08-14 13:31:58+00:00 changed by exarkun

(In [24578]) apply msnfixes.2.patch and fix rejections

refs #702

  2008-08-14 14:04:07+00:00 changed by exarkun

  • keywords changed from words, review to words
  • owner set to exarkun

There are some problems. I'll try to fix them.

  2008-08-14 14:34:44+00:00 changed by exarkun

  • priority changed from high to normal

Okay, so, two main problems, which can probably only be fixed by someone who knows the MSN protocol, at least a bit (which I don't):

  • the new test doesn't assert anything (therefore almost all the changes are untested, the only that is verified is that an exception is not raised)
  • the change to the implementation doesn't make any new information available, it only avoids raising an exception (and it is overly complex for just that feature - if that is all that is desired, then it should be simplified). I haven't found the documentation for NOT yet, so I don't know what should happen, but I do see that NOTIFICATION messages are completely ignored by the current protocol implementation.
Note: See TracTickets for help on using tickets.