Opened 4 years ago

Closed 4 years ago

#6956 enhancement closed fixed (fixed)

get rid of twisted.web.http.Request.stack

Reported by: Jean-Paul Calderone Owned by: Jean-Paul Calderone
Priority: normal Milestone:
Component: web Keywords: easy
Cc: jknight Branch:
Author:

Description

It is undocumented, untested, and unused (not to mention useless).

Attachments (1)

6956-1.diff (472 bytes) - added by Adi Roiban 4 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by DefaultCC Plugin

Cc: jknight added

comment:2 Changed 4 years ago by Adi Roiban

@exarkun will you take care of that?

If not, I can work on this.

Thanks!

comment:3 Changed 4 years ago by Jean-Paul Calderone

I wasn't planning to work on it. I can review a patch, though. :)

comment:4 Changed 4 years ago by Adi Roiban

Keywords: review added
Owner: set to Jean-Paul Calderone

I have attached a patch.

It just removes the variable.

I have written an empty topfile... since in a previous review I got feedback that for simple changes the topfile should be emtpy.

Thanks!

Changed 4 years ago by Adi Roiban

Attachment: 6956-1.diff added

comment:5 Changed 4 years ago by Jean-Paul Calderone

Keywords: review removed

Thanks. Looks good to me. (If you could generate your git patches without the a/ b/ prefixes though that'd be great. :)

comment:6 Changed 4 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [41617]) Apply 6956-1.diff - remove unused Request.stack

Author: adiroiban Reviewer: exarkun Fixes: #6956

twisted.web.http.Request had a stack attribute for a long time, set partway through request processing. Nothing ever used this attribute and it isn't needed for anything. So, remove it.

Note: See TracTickets for help on using tickets.