#6839 enhancement assigned
t.n.dns.DNSProtocol and DNSDatagramProtocol should allow an alternative Message parser to be used
|Reported by:||rwall||Owned by:||rwall|
branch-diff, diff-cov, branch-cov, buildbot
In #5675 we've got a new EDNSMessage parser.
But dns.DNSDatagramProtocol and DNSProtocol (TCP) are hardcoded to use the original dns.Message for decoding and encoding wire messages.
Add a new "messageFactory" constructor argument which allows us to supply dns.EDNSMessage (or a factory function).
Make sure all factory arguments are supplied as keywords. This will also allow us to supply a functools.partial instance, where the EDNS specific constructor arguments have been preassigned; without worrying about argument order.
Change History (8)
comment:1 Changed 3 years ago by rwall
- Summary changed from t.n.dns.DNSProtocol and DNSDatagramProtocol should allow and alternative Message parser to be provided to t.n.dns.DNSProtocol and DNSDatagramProtocol should allow an alternative Message parser to be used
comment:5 follow-up: ↓ 7 Changed 3 years ago by tom.prince
- Keywords review removed
- Owner set to rwall
comment:6 Changed 3 years ago by rwall
- Branch changed from branches/dns-protocol-message-factory-6839 to branches/dns-protocol-message-factory-6839-2