Opened 2 years ago

Closed 3 months ago

#6569 defect closed fixed (fixed)

twisted.python.log.DefaultObserver does its own weird thing, doesn't use textFromEventDict

Reported by: glyph Owned by: wsanchez
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/log-default-observer-6569
(diff, github, buildbot, log)
Author: wsanchez Launchpad Bug:

Description

Among other things, this means that DefaultObserver does not safely repr its argument. So, logging stuff like log.msg("Hello", BrokenRepr(), isError=1) will result in an exception and DefaultLogObserver being removed, whereas FileLogObserver will handle it correctly.

Change History (6)

comment:1 Changed 21 months ago by wsanchez

  • Status changed from new to assigned

Accepting, holding for #6750, which should either fix this or make it cleaner to fix.

comment:2 Changed 3 months ago by wsanchez

  • Author set to wsanchez
  • Branch set to branches/log-default-observer-6569

(In [44467]) Branch for #6569.

comment:3 Changed 3 months ago by wsanchez

  • Keywords review added
  • Owner wsanchez deleted
  • Status changed from assigned to new

comment:4 Changed 3 months ago by ralphm

  • Owner set to ralphm
  • Status changed from new to assigned

comment:5 Changed 3 months ago by ralphm

  • Keywords review removed
  • Owner changed from ralphm to wsanchez
  • Status changed from assigned to new

Yay for removing duplicate code. Please merge.

comment:6 Changed 3 months ago by wsanchez

  • Resolution set to fixed
  • Status changed from new to closed

(In [44476]) Merge branches/log-default-observer-6569: Don't raise if DefaultObserver.emit() gets a hostile message.

Author: wsanchez
Reviewer: ralphm
Fixes: #6569

Note: See TracTickets for help on using tickets.