Opened 3 years ago

Last modified 20 months ago

#6530 enhancement new

Add abortConnection to twisted.test.proto_helpers.StringTransport

Reported by: itamar Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch:


Everyone reimplements abortConnection for StringTransport; it should just be built-in.

Change History (3)

comment:1 Changed 3 years ago by exarkun

watch out for the trap, StringTransport doesn't claim to implement ITCPTransport, which is the interface that defines abortConnection`.

comment:2 Changed 3 years ago by itamar

Really ITransport should have abortConnection. So maybe we need to open a bunch of tickets to add abortConnection to other transports, so we can expanded ITransport to include it.

Meanwhile, to deal with this ticket we should add a ITCPStringTransport subclass of StringTransport that has abortConnection plus all the other extra methods of ITCPTransport.

comment:3 Changed 20 months ago by glyph

Be sure to refactor the transport added in #6686 when implementing this.

Note: See TracTickets for help on using tickets.