Opened 5 years ago

Closed 4 years ago

#6239 task closed fixed (fixed)

Merge `twisted/python/_reflectpy3.py` into `twisted/python/reflect.py`

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone: Python-3.x
Component: core Keywords: py3k
Cc: Branch: branches/merge-reflect-py3-6239
branch-diff, diff-cov, branch-cov, buildbot
Author: hawkowl

Description

Also merge the associated test module. See #6183.

Attachments (2)

merge-reflect-py3-6239-1.patch (73.8 KB) - added by Jonathan Ballet 4 years ago.
merge-reflect-py3-6239-2.patch (74.6 KB) - added by Jonathan Ballet 4 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 4 years ago by Jonathan Ballet

Milestone: Python-3.x

This is also related to #5929 (if not a dup).

comment:2 in reply to:  1 Changed 4 years ago by Thijs Triemstra

Resolution: duplicate
Status: newclosed

Replying to multani:

This is also related to #5929 (if not a dup).

Marking it as a duplicate then.

comment:3 Changed 4 years ago by Jean-Paul Calderone

It isn't really a duplicate. Merging the modules is different from porting the unported code in twisted/python/reflect.py.

comment:4 Changed 4 years ago by Jean-Paul Calderone

Resolution: duplicate
Status: closedreopened

I was going to leave this closed because fixing it seemed like it would cause more trouble than it was worth.

However, then I noticed that there are 'two' patches attached to #5929 - one of which is the proposed resolution to this ticket.

So, in the interest of keeping this minimally confusing, I'm fixing this.

comment:6 Changed 4 years ago by Richard Wall

I don't think this can be reviewed until #5929 is merged.

See ticket:5929#comment:34

comment:7 Changed 4 years ago by Jonathan Ballet

Keywords: review removed
Owner: set to Jonathan Ballet
Status: reopenednew

rwall is right, this ticket actually depends on #5929.

I'll put it back in review with the appropriate patch attached when #5929 is done.

comment:8 Changed 4 years ago by Richard Wall

(In [41754]) Merge python3-reflect-5929-2

Author: multani Reviewers: radix, thijs, rwall, glyph Fixes: #5929 Refs: #6239, #6986, #6859

Port most of twisted.python.reflect to Python3.

Porting objgrep posed some problems and has been moved to a separate ticket #6986.

Porting getcurrent and isinst also posed problems and it was decided to deprecate them in #6859.

Changed 4 years ago by Jonathan Ballet

comment:9 Changed 4 years ago by Jonathan Ballet

Keywords: py3k review added

This patch only:

  • moves the content of twisted/python/_reflectpy3.py into twisted/python/reflect.py
  • moves the content of twisted/python/test/test_reflectpy3.py into twisted/test/test_reflect.py
  • changes the import and references to the old module paths to the new ones

Changed 4 years ago by Jonathan Ballet

comment:10 Changed 4 years ago by hawkowl

Author: hawkowl
Branch: branches/merge-reflect-py3-6239

(In [41896]) Branching to merge-reflect-py3-6239.

comment:11 Changed 4 years ago by hawkowl

Owner: Jonathan Ballet deleted

comment:12 Changed 4 years ago by hawkowl

Keywords: review removed

Looks good to me. Will merge.

comment:13 Changed 4 years ago by hawkowl

Resolution: fixed
Status: newclosed

(In [41904]) Merge merge-reflect-py3-6239: Merge twisted/python/_reflectpy3.py into twisted/python/reflect.py

Author: multani Reviewer: hawkowl Fixes: #6239

Merge twisted/python/_reflectpy3.py into twisted/python/reflect.py, along with the associated test cases.

Note: See TracTickets for help on using tickets.