Ticket #6239 task closed fixed

Opened 16 months ago

Last modified 4 weeks ago

Merge `twisted/python/_reflectpy3.py` into `twisted/python/reflect.py`

Reported by: exarkun Owned by:
Priority: normal Milestone: Python-3.x
Component: core Keywords: py3k
Cc: Branch: branches/merge-reflect-py3-6239
(diff, github, buildbot, log)
Author: hawkowl Launchpad Bug:

Description

Also merge the associated test module. See #6183.

Attachments

merge-reflect-py3-6239-1.patch Download (73.8 KB) - added by multani 7 weeks ago.
merge-reflect-py3-6239-2.patch Download (74.6 KB) - added by multani 7 weeks ago.

Change History

1

follow-up: ↓ 2   Changed 11 months ago by multani

  • milestone set to Python-3.x

This is also related to #5929 (if not a dup).

2

in reply to: ↑ 1   Changed 7 months ago by thijs

  • status changed from new to closed
  • resolution set to duplicate

Replying to multani:

This is also related to #5929 (if not a dup).

Marking it as a duplicate then.

3

  Changed 6 months ago by exarkun

It isn't really a duplicate. Merging the modules is different from porting the unported code in twisted/python/reflect.py.

4

  Changed 6 months ago by exarkun

  • status changed from closed to reopened
  • resolution duplicate deleted

I was going to leave this closed because fixing it seemed like it would cause more trouble than it was worth.

However, then I noticed that there are 'two' patches attached to #5929 - one of which is the proposed resolution to this ticket.

So, in the interest of keeping this minimally confusing, I'm fixing this.

5

6

  Changed 3 months ago by rwall

I don't think this can be reviewed until #5929 is merged.

See ticket:5929#comment:34

7

  Changed 3 months ago by multani

  • owner set to multani
  • status changed from reopened to new
  • keywords review removed

rwall is right, this ticket actually depends on #5929.

I'll put it back in review with the appropriate patch attached when #5929 is done.

8

  Changed 7 weeks ago by rwall

(In [41754]) Merge python3-reflect-5929-2

Author: multani Reviewers: radix, thijs, rwall, glyph Fixes: #5929 Refs: #6239, #6986, #6859

Port most of twisted.python.reflect to Python3.

Porting objgrep posed some problems and has been moved to a separate ticket #6986.

Porting getcurrent and isinst also posed problems and it was decided to deprecate them in #6859.

Changed 7 weeks ago by multani

9

  Changed 7 weeks ago by multani

  • keywords py3k review added

This patch only:

  • moves the content of twisted/python/_reflectpy3.py into twisted/python/reflect.py
  • moves the content of twisted/python/test/test_reflectpy3.py into twisted/test/test_reflect.py
  • changes the import and references to the old module paths to the new ones

Changed 7 weeks ago by multani

10

  Changed 4 weeks ago by hawkowl

  • branch set to branches/merge-reflect-py3-6239
  • branch_author set to hawkowl

(In [41896]) Branching to merge-reflect-py3-6239.

11

  Changed 4 weeks ago by hawkowl

  • owner multani deleted

12

  Changed 4 weeks ago by hawkowl

  • keywords review removed

Looks good to me. Will merge.

13

  Changed 4 weeks ago by hawkowl

  • status changed from new to closed
  • resolution set to fixed

(In [41904]) Merge merge-reflect-py3-6239: Merge twisted/python/_reflectpy3.py into twisted/python/reflect.py

Author: multani Reviewer: hawkowl Fixes: #6239

Merge twisted/python/_reflectpy3.py into twisted/python/reflect.py, along with the associated test cases.

Note: See TracTickets for help on using tickets.