Ticket #6236 task closed fixed

Opened 16 months ago

Last modified 16 months ago

Merge `twisted/internet/_endpointspy3.py` into `twisted/internet/endpoints.py`

Reported by: exarkun Owned by: exarkun
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/endpoints-merge-6236
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

Also merge the associated test module. See #6183.

Change History

1

Changed 16 months ago by exarkun

  • branch set to branches/endpoints-merge-6236
  • branch_author set to exarkun

(In [36683]) Branching to 'endpoints-merge-6236'

2

Changed 16 months ago by exarkun

  • owner exarkun deleted
  • keywords review added

 Build results

Once this lands, reviewing #4696 will hopefully be easier.

3

Changed 16 months ago by tom.prince

  • keywords review removed
  • owner set to exarkun

This seems to lack __future__ imports. (The test module lacked it to begin with, but the python3 guide seems to suggest it be there anyway).

There are also a couple of new blank line errors reported by twistedchecker in test_endpoint. All of the reported errors might as well be cleaned up now.

All of the changed code looks correct, and I did a quick scan of the copied code looking at shape, and things seem to be in order.

Please commit after fixing.

4

Changed 16 months ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [36703]) Merge endpoints-merge-6236

Author: exarkun Reviewer: tom.prince Fixes: #6236

Re-integrate the Python 3 ported endpoints implementation into twisted/internet/endpoints.py

Note: See TracTickets for help on using tickets.