Opened 4 years ago

Last modified 4 years ago

#6234 enhancement new

Replace Deprecated Test Case Assertion Methods in twisted.trial

Reported by: Julian Berman Owned by:
Priority: normal Milestone:
Component: trial Keywords:
Cc: Jonathan Lange Branch:
Author:

Description

See #5771.

Note that unlike the rest of the related tickets (#6220 through #6226 and #6230 through #6233) this one requires a bit more care to review (and more was taken to write hopefully). The tests that are specifically testing methods on trial's TestCase are left untouched, still testing the old methods.

Also, there are a few lines of change in twisted/trial/_synctest.py which change the implementation of things like assertSubstring to instead delegate to a non-deprecated method. If there were more I would have put it in its own ticket, but it's only 4-5 lines.

Attachments (1)

trial-deprecate.patch (37.7 KB) - added by Julian Berman 4 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 4 years ago by DefaultCC Plugin

Cc: Jonathan Lange added

Changed 4 years ago by Julian Berman

Attachment: trial-deprecate.patch added

comment:2 Changed 4 years ago by Julian Berman

Keywords: review removed
Note: See TracTickets for help on using tickets.