Ticket #6218 enhancement closed fixed

Opened 16 months ago

Last modified 14 months ago

AbstractMaildirDomain implements IAliasableDomain but doesn't advertise that fact.

Reported by: tom.prince Owned by: thijs
Priority: normal Milestone:
Component: mail Keywords:
Cc: thijs Branch: branches/maildirdomain-iface-6218
(diff, github, buildbot, log)
Author: thijs Launchpad Bug:

Description


Change History

1

  Changed 14 months ago by thijs

  • branch set to branches/maildirdomain-iface-6218
  • branch_author set to thijs

(In [37216]) Branching to 'maildirdomain-iface-6218'

2

  Changed 14 months ago by thijs

(In [37219]) add interface, news file. refs #6218

3

  Changed 14 months ago by thijs

  • cc thijs added
  • keywords review added

Forced a  build, up for review.

4

follow-up: ↓ 6   Changed 14 months ago by tom.prince

  • keywords review removed
  • owner set to thijs
  1. Please add a test (using verifyClass) that it does in fact implement that interface.
  2. Implementing IDomain is redundant, since IAliasableDomain inherits from it.
  3. Similarly, the IAliasableDomain annotation on MaildirDirdbmDomain is now superflous.

Please commit after addressing the above issues.

5

  Changed 14 months ago by thijs

(In [37247]) address review comments. refs #6218

6

in reply to: ↑ 4   Changed 14 months ago by thijs

  • status changed from new to assigned

Replying to tom.prince:

1. Please add a test (using verifyClass) that it does in fact implement that interface. 1. Implementing IDomain is redundant, since IAliasableDomain inherits from it. 1. Similarly, the IAliasableDomain annotation on MaildirDirdbmDomain is now superflous. Please commit after addressing the above issues.

Thanks for the review. Forced a  new build and will merge when its green.

7

  Changed 14 months ago by thijs

  • status changed from assigned to closed
  • resolution set to fixed

(In [37250]) Merge maildirdomain-iface-6218: AbstractMaildirDomain implements IAliasableDomain and is now marked as such.

Author: thijs Reviewer: tom.prince Fixes: #6218

Also updates other interface definitions in maildir with zope.interface's @implementer decorator.

Note: See TracTickets for help on using tickets.