Opened 5 years ago

Closed 4 years ago

#6218 enhancement closed fixed (fixed)

AbstractMaildirDomain implements IAliasableDomain but doesn't advertise that fact.

Reported by: Tom Prince Owned by: Thijs Triemstra
Priority: normal Milestone:
Component: mail Keywords:
Cc: Thijs Triemstra Branch: branches/maildirdomain-iface-6218
branch-diff, diff-cov, branch-cov, buildbot
Author: thijs

Description


Change History (7)

comment:1 Changed 4 years ago by Thijs Triemstra

Author: thijs
Branch: branches/maildirdomain-iface-6218

(In [37216]) Branching to 'maildirdomain-iface-6218'

comment:2 Changed 4 years ago by Thijs Triemstra

(In [37219]) add interface, news file. refs #6218

comment:3 Changed 4 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Keywords: review added

Forced a build, up for review.

comment:4 Changed 4 years ago by Tom Prince

Keywords: review removed
Owner: set to Thijs Triemstra
  1. Please add a test (using verifyClass) that it does in fact implement that interface.
  2. Implementing IDomain is redundant, since IAliasableDomain inherits from it.
  3. Similarly, the IAliasableDomain annotation on MaildirDirdbmDomain is now superflous.

Please commit after addressing the above issues.

comment:5 Changed 4 years ago by Thijs Triemstra

(In [37247]) address review comments. refs #6218

comment:6 in reply to:  4 Changed 4 years ago by Thijs Triemstra

Status: newassigned

Replying to tom.prince:

  1. Please add a test (using verifyClass) that it does in fact implement that interface.
  2. Implementing IDomain is redundant, since IAliasableDomain inherits from it.
  3. Similarly, the IAliasableDomain annotation on MaildirDirdbmDomain is now superflous.

Please commit after addressing the above issues.

Thanks for the review. Forced a new build and will merge when its green.

comment:7 Changed 4 years ago by Thijs Triemstra

Resolution: fixed
Status: assignedclosed

(In [37250]) Merge maildirdomain-iface-6218: AbstractMaildirDomain implements IAliasableDomain and is now marked as such.

Author: thijs Reviewer: tom.prince Fixes: #6218

Also updates other interface definitions in maildir with zope.interface's @implementer decorator.

Note: See TracTickets for help on using tickets.