#6218 enhancement closed fixed (fixed)

AbstractMaildirDomain implements IAliasableDomain but doesn't advertise that fact.

Reported by: tom.prince Owned by: thijs
Priority: normal Milestone:
Component: mail Keywords:
Cc: thijs Branch: branches/maildirdomain-iface-6218
(diff, github, buildbot, log)
Author: thijs Launchpad Bug:

Description


Change History (7)

comment:1 Changed 17 months ago by thijs

  • Author set to thijs
  • Branch set to branches/maildirdomain-iface-6218

(In [37216]) Branching to 'maildirdomain-iface-6218'

comment:2 Changed 17 months ago by thijs

(In [37219]) add interface, news file. refs #6218

comment:3 Changed 17 months ago by thijs

  • Cc thijs added
  • Keywords review added

Forced a build, up for review.

comment:4 follow-up: Changed 17 months ago by tom.prince

  • Keywords review removed
  • Owner set to thijs
  1. Please add a test (using verifyClass) that it does in fact implement that interface.
  2. Implementing IDomain is redundant, since IAliasableDomain inherits from it.
  3. Similarly, the IAliasableDomain annotation on MaildirDirdbmDomain is now superflous.

Please commit after addressing the above issues.

comment:5 Changed 17 months ago by thijs

(In [37247]) address review comments. refs #6218

comment:6 in reply to: ↑ 4 Changed 17 months ago by thijs

  • Status changed from new to assigned

Replying to tom.prince:

  1. Please add a test (using verifyClass) that it does in fact implement that interface.
  2. Implementing IDomain is redundant, since IAliasableDomain inherits from it.
  3. Similarly, the IAliasableDomain annotation on MaildirDirdbmDomain is now superflous.

Please commit after addressing the above issues.

Thanks for the review. Forced a new build and will merge when its green.

comment:7 Changed 17 months ago by thijs

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [37250]) Merge maildirdomain-iface-6218: AbstractMaildirDomain implements IAliasableDomain and is now marked as such.

Author: thijs
Reviewer: tom.prince
Fixes: #6218

Also updates other interface definitions in maildir with zope.interface's @implementer decorator.

Note: See TracTickets for help on using tickets.