Opened 3 years ago

Last modified 3 weeks ago

#6197 enhancement new

Port twisted.web.client.downloadPage to Python 3

Reported by: itamar Owned by:
Priority: lowest Milestone: Python-3.x
Component: web Keywords: review
Cc: jknight Branch: branches/downloadpage-py3-6197
(diff, github, buildbot, log)
Author: hawkowl Launchpad Bug:

Description

Port twisted.web.client.downloadPage and related code should be ported to Python 3 (unless we decide to deprecate it before the port happens).

Attachments (2)

downloadPage.patch (1.2 KB) - added by vmarkovtsev 15 months ago.
downloadPage_getPage.patch (1.6 KB) - added by vmarkovtsev 15 months ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 3 years ago by DefaultCC Plugin

  • Cc jknight added

Changed 15 months ago by vmarkovtsev

comment:2 Changed 15 months ago by vmarkovtsev

My patch does it. It depends on porting web.client.Agent (ticket #7407).

comment:3 Changed 15 months ago by vmarkovtsev

web/test/test_webclient.py is passed 100% without any modifications

Changed 15 months ago by vmarkovtsev

comment:4 Changed 15 months ago by vmarkovtsev

The second patch ports getPage() together with downloadPage().

comment:5 Changed 3 weeks ago by hawkowl

  • Author set to hawkowl
  • Branch set to branches/downloadpage-py3-6197

(In [45480]) Branching to downloadpage-py3-6197.

comment:6 Changed 3 weeks ago by hawkowl

  • Keywords review added

Tests are green. Please review.

Note: See TracTickets for help on using tickets.