Opened 4 years ago

Last modified 4 years ago

#6171 enhancement new

We shouldn't allow adding callbacks to deferreds that have been returned from other callbacks

Reported by: radix Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/inner-deferred-warnback-6171
(github, coverage, patch, buildbot, log)
Author: radix


It's not useful, since the result is thrown away, and if you're doing it, your program is probably buggy.

Change History (3)

comment:1 Changed 4 years ago by radix

  • Author set to radix
  • Branch set to branches/inner-deferred-failback-6171

(In [36332]) Branching to 'inner-deferred-failback-6171'

comment:2 Changed 4 years ago by radix

  • Branch changed from branches/inner-deferred-failback-6171 to branches/inner-deferred-warnback-6171

(In [36334]) Branching to 'inner-deferred-warnback-6171'

comment:3 Changed 4 years ago by radix

There was one change outside of the Deferred tests that have this behavior; test_manhole was returning a Deferred from a callback that was later having an errback added to it in tearDown (which would never be fired).

Note: See TracTickets for help on using tickets.