Ticket #6171 enhancement new

Opened 18 months ago

Last modified 18 months ago

We shouldn't allow adding callbacks to deferreds that have been returned from other callbacks

Reported by: radix Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/inner-deferred-warnback-6171
(diff, github, buildbot, log)
Author: radix Launchpad Bug:

Description

It's not useful, since the result is thrown away, and if you're doing it, your program is probably buggy.

Change History

1

Changed 18 months ago by radix

  • branch set to branches/inner-deferred-failback-6171
  • branch_author set to radix

(In [36332]) Branching to 'inner-deferred-failback-6171'

2

Changed 18 months ago by radix

  • branch changed from branches/inner-deferred-failback-6171 to branches/inner-deferred-warnback-6171

(In [36334]) Branching to 'inner-deferred-warnback-6171'

3

Changed 18 months ago by radix

There was one change outside of the Deferred tests that have this behavior; test_manhole was returning a Deferred from a callback that was later having an errback added to it in tearDown (which would never be fired).

Note: See TracTickets for help on using tickets.