Ticket #6158 enhancement closed fixed

Opened 18 months ago

Last modified 18 months ago

Port twisted.python.util.nameToLabel to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/nameToLabel-py3-6158
(diff, github, buildbot, log)
Author: itamarst Launchpad Bug:

Description

nameToLabel is required by _sslverify.py, so should be ported to Python 3.

Change History

1

Changed 18 months ago by itamarst

  • branch set to branches/nameToLabel-py3-6158
  • branch_author set to itamarst

(In [36248]) Branching to 'nameToLabel-py3-6158'

2

Changed 18 months ago by itamar

  • owner set to exarkun
  • keywords review added

Ready for review, tests are running -  http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/nameToLabel-py3-6158

This is a trivial port.

3

Changed 18 months ago by exarkun

  • keywords review removed
  • owner changed from exarkun to itamar

nameToLabel seems to be missing some test coverage. Add it now if you feel like it, otherwise file a ticket for addressing that.

Should we start a section in the porting howto that's just a list of APIs which took str before and changed to take str in Python 3?

Otherwise looks good, please merge when you're happy with respect to these two points.

4

Changed 18 months ago by itamar

  1. #6160
  2. We already have some things, I thought, like log.msg()? In this particular case, however, the API documentation is very clear that it takes a "string that could be a Python identifier", so the behaviour on Python 3 should be clear to anyone who's used this API before.

5

Changed 18 months ago by itamarst

  • status changed from new to closed
  • resolution set to fixed

(In [36251]) Merge nameToLabel-py3-6158.

Author: itamar Review: exarkun Fixes: #6158

Port twisted.python.util.nameToLabel to Python 3.

Note: See TracTickets for help on using tickets.