Port twisted.internet.ssl to Python 3

[itamar]

twisted.internet.ssl should run on Python 3.

[itamarst]

(In [36308]) Branching to 'ssl-py3-6142'

[itamar]

This will include twisted.test.test_ssl, but not twisted.internet.test.test_tls, which depends on SSL endpoints (#6157), which in turn depends on this ticket. test_tls will have to be done separately as a result.

[itamar]

Ready for review;  https://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/ssl-py3-6142 is running.

1. Re-enabled various places where SSL was disabled on Python 3.
2. Usual minor fixes.
3. Removed a little bit of duplication (e.g certPath) in the test code.

[exarkun]

Thanks.

1. twisted/test/test_ssl.py
   1. in generateCertificateFiles, FilePath.setContent is better than open/write/close.
   2. likewise for FilePath.getContent in StolenTCPTestCase.createServer
   3. ConnectionLostTestCase.test_bothSidesLoseConnection does a transport.write("a") - ie native instead of byte string. This should cause a test failure...
   4. Do any of these tests run? They all skip on the Python 3.3 builder and locally.
2. Some code being changed has comments about ticket #6141 - not #6142?

[itamar]

1.1, 1.2: Fixed. 1.3: Apparently SSL.Connection.send will accept unicode. I added a hack to twisted.protocols.tls that will catch this. I also fixed the test. 1.4: They all run... if you have pyOpenSSL installed. The buildslave doesn't, but you can install it locally. I'll email Barry about improving our buildslave setup.

2: Those comments were somewhat inaccurate, the imports should probably be from the public module (i.e. twisted.internet.ssl), not _sslverify. In any case I missed them when porting _sslverify (#6141), and doing it here is reasonable since this is the public API exposing _sslverify.

 http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/ssl-py3-6142 is running.  http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/ssl-py3-6142

[exarkun]

Okay, thanks. Please merge.

[itamarst]

(In [36350]) Merge ssl-py3-6142.

Author: itamar Review: exarkun Fixes: #6142

Port twisted.internet.ssl to Python 3.