Ticket #6141 enhancement closed fixed

Opened 7 months ago

Last modified 7 months ago

Port twisted.internet._sslverify to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/sslverify-py3-6141-2
Author: itamarst Launchpad Bug:

Description

twisted.internet._sslverify should run on Python 3.

(Possibly unnecessary for initial milestone.)

Change History

1

Changed 7 months ago by itamarst

  • branch set to branches/sslverify-py3-6141
  • branch_author set to itamarst

(In [36245]) Branching to 'sslverify-py3-6141'

2

Changed 7 months ago by itamarst

  • branch changed from branches/sslverify-py3-6141 to branches/sslverify-py3-6141-2

(In [36252]) Branching to 'sslverify-py3-6141-2'

3

Changed 7 months ago by itamar

  • owner set to exarkun
  • keywords review added

OK, did enough of a port that I think we can use this as a dependency.

 http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/sslverify-py3-6141-2 is running.

#6156 opened for missing tests.

4

Changed 7 months ago by exarkun

  • keywords review removed
  • owner changed from exarkun to itamar

Thanks.

  1. twisted/internet/_sslverify.py
    1. Can you nuke the duplicate TML copyright header?
    2. DistinguishedName looks like it needs some better documentation about its initializer arguments and attributes (particularly the types of their values).
  2. twisted/test/test_sslverify.py
    1. test_allowedAnonymousClientConnection shouldn't have a custom timeout
    2. Why is the twisted.python.log import moved inside test_allowedAnonymousClientConnection?
    3. I think the old version of test_certificateOptionsSerialization was actually better. The useful assertion is "this object has no reference to that object". Now the assertion is "this particular reference in this object is not a reference to that object", which is much weaker. However, since it's a test for pickle support which I think we should give up pretending to offer, who cares? Perhaps file a new ticket for deprecating these __getstate__/__setstate__ and we can eventually delete them and this test.

5

Changed 7 months ago by itamarst

(In [36292]) Remove duplicate copyright, write better docstring for DistinguishedName. Refs #6141

6

Changed 7 months ago by itamarst

(In [36294]) Remove some debugging code that was left in by mistake. Refs #6141

7

Changed 7 months ago by itamar

  • owner changed from itamar to exarkun
  • keywords review added
  1. Done, in r36292 and r363293.
  2. Removed timeouts and logging code (just there for debugging) in r36294. Opened #6166 for deprecating pickling support (I assume you're OK with leaving the pickling test in its current state).

Started new build:  http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/sslverify-py3-6141-2

8

Changed 7 months ago by itamar

Make that r36293.

9

Changed 7 months ago by exarkun

  • keywords review removed
  • owner changed from exarkun to itamar

Great, thanks. I am indeed okay with the current state of the pickling test. Please merge.

10

Changed 7 months ago by itamarst

  • status changed from new to closed
  • resolution set to fixed

(In [36306]) Merge sslverify-py3-6141-2.

Author: itamar Review: exarkun Fixes: #6141

Port sslverify (in so far as test coverage allows) to Python 3.

Note: See TracTickets for help on using tickets.