Opened 4 years ago

Closed 19 months ago

#6136 enhancement closed fixed (fixed)

Reenable Py3 tests in test.test_loopback

Reported by: Jean-Paul Calderone Owned by: hawkowl
Priority: normal Milestone: Python-3.x
Component: core Keywords:
Cc: Branch: branches/loopback-py3-6136
branch-diff, diff-cov, branch-cov, buildbot
Author:

Description (last modified by hawkowl)

IReactorUNIX is implemented and works, so now update a test that incorrectly skips.

Change History (8)

comment:1 Changed 4 years ago by Jean-Paul Calderone

twisted.test.test_loopback has some tests skipped that should be unskipped when this is resolved.

comment:2 Changed 4 years ago by nott_

Owner: set to nott_

comment:3 Changed 19 months ago by hawkowl

Owner: changed from nott_ to hawkowl

This has been fixed in trunk but the tests haven't been unskipped. Lemme fix that.

comment:4 Changed 19 months ago by hawkowl

Branch: branches/loopback-py3-6136

comment:5 Changed 19 months ago by hawkowl

Description: modified (diff)
Keywords: review added
Owner: hawkowl deleted
Summary: Port twisted.internet.test.test_unix and twisted.test.test_unix to Python 3Reenable Py3 tests in test.test_loopback

comment:6 Changed 19 months ago by hawkowl

Builders spun, please review.

comment:7 Changed 19 months ago by Adi Roiban

Keywords: review removed
Owner: set to hawkowl

twisted.test.test_process.PosixProcessPTYTests.test_executionError was failing... I have re-run it and it is green.

please merge. thanks!

comment:8 Changed 19 months ago by hawkowl

Resolution: fixed
Status: newclosed

(In [45178]) Merge loopback-py3-6136: Re-enable UNIX tests in test_loopback on Py3

Author: hawkowl Reviewer: adiroiban Fixes: #6136

Note: See TracTickets for help on using tickets.