#6109 enhancement closed fixed (fixed)

Port twisted.protocols.loopback to Python 3

Reported by: exarkun Owned by: exarkun
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/loopback-py3-6109-2
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

Some HTTP tests use it, so it would at least help get full test coverage for Twisted Web.

Change History (7)

comment:1 Changed 23 months ago by exarkun

  • Milestone changed from Python-3.x to Python 3.3 Minimal
  • Owner set to exarkun
  • Status changed from new to assigned

SSL unit tests also need this, so I guess it is part of the minimal subset.

comment:2 Changed 23 months ago by exarkun

  • Author set to exarkun
  • Branch set to branches/loopback-py3-6109

(In [36183]) Branching to 'loopback-py3-6109'

comment:3 Changed 23 months ago by exarkun

  • Keywords review added
  • Owner changed from exarkun to itamar
  • Status changed from assigned to new

Build results. Test coverage for loopbackAsync seems pretty good, and that's all we care about I think.

comment:4 Changed 23 months ago by itamar

  • Keywords review removed
  • Owner changed from itamar to exarkun

Thanks!

  1. LoopbackRelay has a bunch of strings that need to be converted to bytes.
  2. Open a ticket for missing tests.

Fix, then merge.

comment:5 Changed 23 months ago by exarkun

  • Branch changed from branches/loopback-py3-6109 to branches/loopback-py3-6109-2

(In [36199]) Branching to 'loopback-py3-6109-2'

comment:6 Changed 23 months ago by exarkun

Thanks!

LoopbackRelay has a bunch of strings that need to be converted to bytes.

Moved the module to the not-quite-ported list instead - r36201.

Open a ticket for missing tests.

Opened #6138

comment:7 Changed 23 months ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [36203]) Merge loopback-py3-6109-2

Author: exarkun
Reviewer: itamarst
Fixes: #6109

Port twisted.protocols.loopback.loopbackAsync to Python 3.

Note: See TracTickets for help on using tickets.