Ticket #6109 enhancement closed fixed

Opened 8 months ago

Last modified 8 months ago

Port twisted.protocols.loopback to Python 3

Reported by: exarkun Owned by: exarkun
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/loopback-py3-6109-2
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

Some HTTP tests use it, so it would at least help get full test coverage for Twisted Web.

Change History

1

Changed 8 months ago by exarkun

  • status changed from new to assigned
  • owner set to exarkun
  • milestone changed from Python-3.x to Python 3.3 Minimal

SSL unit tests also need this, so I guess it is part of the minimal subset.

2

Changed 8 months ago by exarkun

  • branch set to branches/loopback-py3-6109
  • branch_author set to exarkun

(In [36183]) Branching to 'loopback-py3-6109'

3

Changed 8 months ago by exarkun

  • keywords review added
  • owner changed from exarkun to itamar
  • status changed from assigned to new

 Build results. Test coverage for loopbackAsync seems pretty good, and that's all we care about I think.

4

Changed 8 months ago by itamar

  • keywords review removed
  • owner changed from itamar to exarkun

Thanks!

  1. LoopbackRelay has a bunch of strings that need to be converted to bytes.
  2. Open a ticket for missing tests.

Fix, then merge.

5

Changed 8 months ago by exarkun

  • branch changed from branches/loopback-py3-6109 to branches/loopback-py3-6109-2

(In [36199]) Branching to 'loopback-py3-6109-2'

6

Changed 8 months ago by exarkun

Thanks!

LoopbackRelay has a bunch of strings that need to be converted to bytes.

Moved the module to the not-quite-ported list instead - r36201.

Open a ticket for missing tests.

Opened #6138

7

Changed 8 months ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [36203]) Merge loopback-py3-6109-2

Author: exarkun Reviewer: itamarst Fixes: #6109

Port twisted.protocols.loopback.loopbackAsync to Python 3.

Note: See TracTickets for help on using tickets.