#6103 enhancement closed fixed (fixed)

Port twisted.internet.posixbase to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/posixbase-py3-6103-2
(diff, github, buildbot, log)
Author: itamarst Launchpad Bug:

Description

twisted.internet.posixbase should run on Python 3.

Change History (8)

comment:1 Changed 23 months ago by itamarst

  • Author set to itamarst
  • Branch set to branches/posixbase-py3-6103

(In [36123]) Branching to 'posixbase-py3-6103'

comment:2 Changed 23 months ago by itamar

Notes for when this is in review:

  1. This is only a limited port; obviously many of the methods (e.g. process support) are untested.
  2. I moved some tests, unchanged, from test_posixbase to the more appropriate twisted.test.test_unix and twisted.test.test_tcp_internals (I chose those because we're trying to move twisted.internet.test towards ReactorBuilder, with twisted.test being the old crufty stuff that needs rethinking/rewriting).

comment:3 Changed 23 months ago by itamar

  • Keywords review added
  • Owner changed from itamar to exarkun

comment:4 Changed 23 months ago by exarkun

  • Keywords review removed
  • Owner changed from exarkun to itamar

Thanks.

  1. The test organization was pretty bad before, but I'm not sure this move is a huge improvement. Adding more code to the modules we're trying to get rid of is an obvious step backwards. I think it's incorrect to say we're trying to move twisted.internet.test towards ReactorBuilder. Rather, we're trying to move blackbox reactor testing towards ReactorBuilder, and we're trying to move tests for code in twisted.internet into twisted.internet.test. I think the two choices we have now, twisted.internet.test.test_posixbase and twisted.test.test_tcp, are both pretty bad, and really a symptom of another problem: twisted.internet.posixbase should really be part of a new twisted.internet package, posixreactor or something - a sibling of iocpreactor. Squishing it down into twisted.internet leads to confusion and poor naming.

Hmm. And that's really all that's happening in this branch, so that's all I have to say about it I guess. :)

comment:5 Changed 23 months ago by itamarst

  • Branch changed from branches/posixbase-py3-6103 to branches/posixbase-py3-6103-2

(In [36166]) Branching to 'posixbase-py3-6103-2'

comment:6 Changed 23 months ago by itamar

  • Keywords review added
  • Owner changed from itamar to exarkun

OK, I moved tests back into test_posixbase.

http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/posixbase-py3-6103-2 is/will be running.

comment:7 Changed 23 months ago by exarkun

  • Keywords review removed
  • Owner changed from exarkun to itamar

Looks good, please merge.

comment:8 Changed 23 months ago by itamarst

  • Resolution set to fixed
  • Status changed from new to closed

(In [36184]) Merge posixbase-py3-6103-2.

Author: itamar
Review: exarkun
Fixes: #6103

Port most of twisted.internet.posixbase to Python 3 (Windows and process support are untested).

Note: See TracTickets for help on using tickets.