Opened 4 years ago

Closed 4 years ago

#6100 enhancement closed fixed (fixed)

Port twisted.python.reflect.prefixedMethodNames to Python 3

Reported by: exarkun Owned by: exarkun
Priority: normal Milestone: Python 3.3 Minimal
Component: web Keywords:
Cc: jknight Branch: branches/prefixedmethodnames-py3-6100
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun


This is needed by twisted.web.resource.

Change History (7)

comment:1 Changed 4 years ago by DefaultCC Plugin

  • Cc jknight added

comment:2 Changed 4 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/prefixedmethodnames-py3-6100

(In [36105]) Branching to 'prefixedmethodnames-py3-6100'

comment:3 Changed 4 years ago by exarkun

(In [36106]) Move prefixedMethodNames and helper to and port it to Python 3; add some tests for it, since it had none.

refs #6100

comment:4 Changed 4 years ago by exarkun

  • Keywords review added
  • Owner changed from exarkun to itamar

Easy, almost just a move. Build results

comment:5 Changed 4 years ago by itamar

  • Keywords review removed
  • Owner changed from itamar to exarkun
  1. test_inheritedMethod isn't actually checking methods on Child.
  2. addMethodNamesToDict is horrible - new ticket?

Otherwise good, fix then merge.

comment:6 Changed 4 years ago by exarkun

(In [36140]) Fix new test to use child class

refs #6100

comment:7 Changed 4 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [36141]) Merge prefixedmethodnames-py3-6100

Author: exarkun Reviewer: itamarst Fixes: #6100

Port prefixedMethodNames to Python 3.

Note: See TracTickets for help on using tickets.