Ticket #6100 enhancement closed fixed

Opened 18 months ago

Last modified 18 months ago

Port twisted.python.reflect.prefixedMethodNames to Python 3

Reported by: exarkun Owned by: exarkun
Priority: normal Milestone: Python 3.3 Minimal
Component: web Keywords:
Cc: jknight Branch: branches/prefixedmethodnames-py3-6100
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

This is needed by twisted.web.resource.

Change History

1

Changed 18 months ago by DefaultCC Plugin

  • cc jknight added

2

Changed 18 months ago by exarkun

  • branch set to branches/prefixedmethodnames-py3-6100
  • branch_author set to exarkun

(In [36105]) Branching to 'prefixedmethodnames-py3-6100'

3

Changed 18 months ago by exarkun

(In [36106]) Move prefixedMethodNames and helper to _reflectpy3.py and port it to Python 3; add some tests for it, since it had none.

refs #6100

4

Changed 18 months ago by exarkun

  • keywords review added
  • owner changed from exarkun to itamar

Easy, almost just a move.  Build results

5

Changed 18 months ago by itamar

  • owner changed from itamar to exarkun
  • keywords review removed
  1. test_inheritedMethod isn't actually checking methods on Child.
  2. addMethodNamesToDict is horrible - new ticket?

Otherwise good, fix then merge.

6

Changed 18 months ago by exarkun

(In [36140]) Fix new test to use child class

refs #6100

7

Changed 18 months ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [36141]) Merge prefixedmethodnames-py3-6100

Author: exarkun Reviewer: itamarst Fixes: #6100

Port prefixedMethodNames to Python 3.

Note: See TracTickets for help on using tickets.