Opened 5 years ago

Closed 5 years ago

#6100 enhancement closed fixed (fixed)

Port twisted.python.reflect.prefixedMethodNames to Python 3

Reported by: Jean-Paul Calderone Owned by: Jean-Paul Calderone
Priority: normal Milestone: Python 3.3 Minimal
Component: web Keywords:
Cc: jknight Branch: branches/prefixedmethodnames-py3-6100
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

This is needed by twisted.web.resource.

Change History (7)

comment:1 Changed 5 years ago by DefaultCC Plugin

Cc: jknight added

comment:2 Changed 5 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/prefixedmethodnames-py3-6100

(In [36105]) Branching to 'prefixedmethodnames-py3-6100'

comment:3 Changed 5 years ago by Jean-Paul Calderone

(In [36106]) Move prefixedMethodNames and helper to _reflectpy3.py and port it to Python 3; add some tests for it, since it had none.

refs #6100

comment:4 Changed 5 years ago by Jean-Paul Calderone

Keywords: review added
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring

Easy, almost just a move. Build results

comment:5 Changed 5 years ago by Itamar Turner-Trauring

Keywords: review removed
Owner: changed from Itamar Turner-Trauring to Jean-Paul Calderone
  1. test_inheritedMethod isn't actually checking methods on Child.
  2. addMethodNamesToDict is horrible - new ticket?

Otherwise good, fix then merge.

comment:6 Changed 5 years ago by Jean-Paul Calderone

(In [36140]) Fix new test to use child class

refs #6100

comment:7 Changed 5 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [36141]) Merge prefixedmethodnames-py3-6100

Author: exarkun Reviewer: itamarst Fixes: #6100

Port prefixedMethodNames to Python 3.

Note: See TracTickets for help on using tickets.