Opened 4 years ago

Closed 4 years ago

#6097 enhancement closed fixed (fixed)

Port twisted.protocols.policies to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/policies-py3-6097
branch-diff, diff-cov, branch-cov, buildbot
Author: itamarst


twisted.protocols.policies should run on Python 3 (it's required by twisted.protocols.tls).

Change History (4)

comment:1 Changed 4 years ago by itamarst

  • Author set to itamarst
  • Branch set to branches/policies-py3-6097

(In [36089]) Branching to 'policies-py3-6097'

comment:2 Changed 4 years ago by itamar

  • Keywords review added
  • Owner changed from itamar to exarkun

Ready for review, I think: has started.

  1. I improved coverage on ProtocolWrapper and WrappedFactory, which are what we really care about. Coverage is still imperfect elsewhere.
  2. For the logging factory, I decided to keep it as native strings written to the file; since it writes a repr() of the traffic, that doesn't seem like much of a problem.

comment:3 Changed 4 years ago by exarkun

  • Keywords review removed
  • Owner changed from exarkun to itamar
  1. Typo in _getWrapper docstring - conncected
  2. ... stopConsuming? Uh, ok whatever...

Looks good otherwise, please merge after addressing the above.

comment:4 Changed 4 years ago by itamarst

  • Resolution set to fixed
  • Status changed from new to closed

(In [36096]) Merge policies-py3-6097.

Author: itamar Review: exarkun Fixes: #6097

Port twisted.protocols.policies to Python 3.

Note: See TracTickets for help on using tickets.