Ticket #6091 enhancement closed fixed

Opened 8 months ago

Last modified 8 months ago

Remove (immediately and with all haste) `IResolver.lookupRecord`

Reported by: exarkun Owned by: exarkun
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/remove-lookuprecord-6091
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description (last modified by exarkun) (diff)

This method of the IResolver interface has no implementation in Twisted and has never had an implementation in Twisted. It is a documentation error.

I propose that this is acceptable without deprecation because:

  • Twisted has never included an implementation of this method for applications to call.
  • Twisted has never called this method on any object, either defined by Twisted or supplied by an application.
  • It is redundant with query.
  • Any application code which was implementing this method for some reason of its own will be unaffected by the removal of the method from the interface.

Change History

1

Changed 8 months ago by exarkun

  • branch set to branches/remove-lookuprecord-6091
  • branch_author set to exarkun

(In [36047]) Branching to 'remove-lookuprecord-6091'

2

Changed 8 months ago by exarkun

  • owner changed from exarkun to itamar
  • keywords review added
  • description modified (diff)

There, I removed it. No deprecation or anything, just bam gone.

3

Changed 8 months ago by therve

  • owner changed from itamar to exarkun
  • keywords review removed

I like it. Please merge.

4

Changed 8 months ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [36069]) Merge remove-lookuprecord-6091

Author: exarkun Reviewer: therve Fixes: #6091

Remove twisted.internet.interfaces.IResolver.lookupRecord, a bogus method that was never implemented or used.

Note: See TracTickets for help on using tickets.