Ticket #6088 enhancement closed fixed

Opened 7 months ago

Last modified 7 months ago

Port twisted.internet.endpoint's tcp endpoints to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/endpoints-py3-6088
Author: itamarst Launchpad Bug:

Description (last modified by itamar) (diff)

twisted.internet.endpoints should be ported to Python 3, in a minimal fashion, speicifically TCP (necessary for #6069) to begin with.

Change History

1

Changed 7 months ago by itamarst

  • branch set to branches/endpoints-py3-6088
  • branch_author set to itamarst

(In [36030]) Branching to 'endpoints-py3-6088'

2

Changed 7 months ago by itamar

  • description modified (diff)

3

Changed 7 months ago by itamar

  • description modified (diff)

4

Changed 7 months ago by itamar

  • keywords review added
  • owner changed from itamar to exarkun

 http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/endpoints-py3-6088 is running.

5

Changed 7 months ago by exarkun

  • keywords review removed
  • owner changed from exarkun to itamar
  1. twisted/internet/endpoints.py imports _WrappingProtocol but does not use it
  2. twisted/internet/_endpointspy3.py is missing __future__ imports

I reviewed the moved code for differences and didn't find any of significance. I would have been confident to skip that step given a note mentioning none of the code had changed (apart from implements/implementer).

Looks good apart from those two points, please merge when they're resolved.

6

Changed 7 months ago by exarkun

Oh damn, I forgot to be snarky.

  1. I don't see any ported UDP code, did you forget to do that?

7

Changed 7 months ago by itamar

  • description modified (diff)
  • summary changed from Port twisted.internet.endpoint's tcp and udp endpoints to Python 3 to Port twisted.internet.endpoint's tcp endpoints to Python 3

8

Changed 7 months ago by itamarst

  • status changed from new to closed
  • resolution set to fixed

(In [36083]) Merge endpoints-py3-6088.

Author: itamar Review: exarkun Fixes: #6088

Port TCP endpoints to Python 3.

Note: See TracTickets for help on using tickets.