#6088 enhancement closed fixed (fixed)

Port twisted.internet.endpoint's tcp endpoints to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/endpoints-py3-6088
(diff, github, buildbot, log)
Author: itamarst Launchpad Bug:

Description (last modified by itamar)

twisted.internet.endpoints should be ported to Python 3, in a minimal fashion, speicifically TCP (necessary for #6069) to begin with.

Change History (8)

comment:1 Changed 23 months ago by itamarst

  • Author set to itamarst
  • Branch set to branches/endpoints-py3-6088

(In [36030]) Branching to 'endpoints-py3-6088'

comment:2 Changed 23 months ago by itamar

  • Description modified (diff)

comment:3 Changed 23 months ago by itamar

  • Description modified (diff)

comment:4 Changed 23 months ago by itamar

  • Keywords review added
  • Owner changed from itamar to exarkun

comment:5 Changed 23 months ago by exarkun

  • Keywords review removed
  • Owner changed from exarkun to itamar
  1. twisted/internet/endpoints.py imports _WrappingProtocol but does not use it
  2. twisted/internet/_endpointspy3.py is missing __future__ imports

I reviewed the moved code for differences and didn't find any of significance. I would have been confident to skip that step given a note mentioning none of the code had changed (apart from implements/implementer).

Looks good apart from those two points, please merge when they're resolved.

comment:6 Changed 23 months ago by exarkun

Oh damn, I forgot to be snarky.

  1. I don't see any ported UDP code, did you forget to do that?

comment:7 Changed 23 months ago by itamar

  • Description modified (diff)
  • Summary changed from Port twisted.internet.endpoint's tcp and udp endpoints to Python 3 to Port twisted.internet.endpoint's tcp endpoints to Python 3

comment:8 Changed 23 months ago by itamarst

  • Resolution set to fixed
  • Status changed from new to closed

(In [36083]) Merge endpoints-py3-6088.

Author: itamar
Review: exarkun
Fixes: #6088

Port TCP endpoints to Python 3.

Note: See TracTickets for help on using tickets.