Opened 4 years ago

Closed 4 years ago

#6080 enhancement closed fixed (fixed)

Port twisted.web.http_headers to Python 3

Reported by: Jean-Paul Calderone Owned by: Jean-Paul Calderone
Priority: normal Milestone: Python 3.3 Minimal
Component: web Keywords:
Cc: jknight Branch: branches/http-headers-py3-6080
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

This is a dependency of both the client and the server.

Change History (7)

comment:1 Changed 4 years ago by DefaultCC Plugin

Cc: jknight added

comment:2 Changed 4 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/http-headers-py3-6080

(In [36003]) Branching to 'http-headers-py3-6080'

comment:3 Changed 4 years ago by Jean-Paul Calderone

Keywords: review added
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring

Switched it to MutableMapping which wasn't too bad, but it's not quite mechanical. Build results.

comment:4 Changed 4 years ago by Thijs Triemstra

#5829 was opened for MutableMapping, so that is either a duplicate or it should be referenced/closed when merging this ticket.

comment:5 Changed 4 years ago by Itamar Turner-Trauring

Keywords: review removed
Owner: changed from Itamar Turner-Trauring to Jean-Paul Calderone

Looks good, with two minor fixes; merge when done:

  1. Add twisted.web.test to _twistedpython3.py.
  2. Some of the methods still refer to C{str} and strings instead of bytes, e.g. hasHeader, removeHeader, etc..

comment:6 Changed 4 years ago by Jean-Paul Calderone

(In [36040]) Address review comments

refs #6080

comment:7 Changed 4 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [36042]) Merge http-headers-py3-6080

Author: exarkun Reviewer: itamarst Fixes: #6080

Port twisted.web.http_headers to Python 3. Also fix some structural documentation issues.

Note: See TracTickets for help on using tickets.