Ticket #6069 enhancement closed fixed

Opened 7 months ago

Last modified 7 months ago

Port twisted.internet.test.test_tcp and connectionmixins to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/tcp-py3-6069-3
Author: itamarst Launchpad Bug:

Description (last modified by itamar) (diff)

In the interest of making #6002 smaller, twisted.internet.test.test_tcp and twisted.internet.test.connectionmixins should be ported to Python 3 on their own.

Change History

1

Changed 7 months ago by itamarst

  • branch set to branches/tcp-py3-6069
  • branch_author set to itamarst

(In [35994]) Branching to 'tcp-py3-6069'

2

Changed 7 months ago by itamar

  • description modified (diff)

3

Changed 7 months ago by itamarst

  • branch changed from branches/tcp-py3-6069 to branches/tcp-py3-6069-2

(In [36084]) Branching to 'tcp-py3-6069-2'

4

Changed 7 months ago by itamarst

  • branch changed from branches/tcp-py3-6069-2 to branches/tcp-py3-6069-3

(In [36157]) Branching to 'tcp-py3-6069-3'

5

Changed 7 months ago by itamar

  • owner changed from itamar to exarkun
  • keywords review added

Ready for review, I think.  http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/tcp-py3-6069-3

Only non-test code change was changing order of checks in abstract.py so that you don't compare ConnectionLost to an integer, which fails on Python 3.

6

Changed 7 months ago by exarkun

  • owner changed from exarkun to itamar
  • keywords review removed

Thanks.

  1. Maybe connect in twisted/internet/test/test_tcp.py should have a docstring, at least describing what shape destination should have, now that it is less self-describing in the signature.
  2. Add a reference to #6070 to the chr function in posixifaces.py.

That's all. Please merge after fixing the above.

7

Changed 7 months ago by itamarst

  • status changed from new to closed
  • resolution set to fixed

(In [36190]) Merge tcp-py3-6069-3.

Author: itamar Review: exarkun Fixes: #6069

twisted.internet.test.test_tcp is now ported to Python 3.

Note: See TracTickets for help on using tickets.