Opened 2 years ago

Closed 2 years ago

#6068 enhancement closed fixed (fixed)

Port select, poll and epoll reactors to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/reactors-py3-6068
(diff, github, buildbot, log)
Author: itamarst Launchpad Bug:

Description

We've got enough test coverage at this point in trunk, or branches, that porting select, poll and epoll seems reasonable.

Change History (5)

comment:1 Changed 2 years ago by itamarst

  • Author set to itamarst
  • Branch set to branches/reactors-py3-6068

(In [35992]) Branching to 'reactors-py3-6068'

comment:2 Changed 2 years ago by itamar

  • Keywords review added
  • Owner changed from itamar to exarkun

comment:3 Changed 2 years ago by exarkun

  • Keywords review removed
  • Owner changed from exarkun to itamar

Urrr really? How is that possible? I guess even if the modules are "ported" that doesn't mean the reactor-related tests in twisted.internet.test are passing. So... okay? I guess? Clearly I'm slightly confused by this, but it doesn't seem wrong... Go ahead and merge, if you know where you're going next (maybe write down where you're going next though).

comment:4 Changed 2 years ago by itamar

These modules only really provide IReactorFDSet, so it seems reasonable to merge this once test_udp and test_tcp are passing.

comment:5 Changed 2 years ago by itamarst

  • Resolution set to fixed
  • Status changed from new to closed

(In [36155]) Merge reactors-py3-6068.

Author: itamar
Review: exarkun
Fixes: #6068

select, poll and epoll reactors are deemed to be sufficiently working on Python 3, given passing TCP, UDP and fdset tests.

Note: See TracTickets for help on using tickets.