Create utility function for getting name of a function for use by __str__

[itamar]

Various places in Twisted (LoopingCall, DelayedCall) have logic for getting a string representation of functions. This logic should be unified in a single utility function in twisted.python.reflect.

[borko]

diff v1

[itamar]

Thanks for submitting this! It's very nice to get patches with tests.

1. I will note that we're trying to get rid of _reflectpy3 (see #6183), but until then if you've added code to _reflectpy3 you should make sure it's publicly available from twisted.python.reflect (i.e. appears in __all__ in the latter module).
2. The docstring for getFunctionName indicates it will return None, which is not the case.
3. I would call the argument to getFunctionName something like function; Python doesn't have pointers.
4. You need a test for the safe_repr() case, if I'm not mistaken.
5. Your tests talk about the "second argument", but there is only one argument.

[itamar]

Please fix the above and resubmit.

[borko]

diff 2

[borko]

Thx for fast answer! 1. Do we want to dispose of the reflectpy3 file by slowly porting all the code to reflectpy ? Or move it to other modules ?

[itamar]

We'll restore the code to its original home in reflect.py, using a slightly tricky procedure since we want to preserve version control history and pretend _reflectpy3.py never happened.

[borko]

second patch created. waiting for acceptance.

[itamarst]

(In [36575]) Branching to 'functionname-6066'

[itamar]

Looks good, just needs slightly better descriptions and a news file; I will do that and merge.

[itamarst]

(In [36601]) Apply patch, with some minor fixes. Refs #6066