Ticket #6065 enhancement closed fixed

Opened 8 months ago

Last modified 8 months ago

Port twisted.internet.base to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/base-py3-6065-2
Author: itamarst Launchpad Bug:

Description

twisted.internet.base should run on Python 3.

Change History

1

Changed 8 months ago by itamarst

  • branch set to branches/base-py3-6065
  • branch_author set to itamarst

(In [35978]) Branching to 'base-py3-6065'

2

Changed 8 months ago by itamar

  • owner set to exarkun
  • keywords review added

3

Changed 8 months ago by itamar

You'll want the 2nd build. Sigh.

4

Changed 8 months ago by itamar

  • keywords review removed

Taking it back from review, discovered another relevant test module.

5

Changed 8 months ago by itamar

  • keywords review added

6

Changed 8 months ago by exarkun

  • owner changed from exarkun to itamar
  • keywords review removed

Thanks.

  1. DelayedCallTests in twisted.test.test_internet belongs somewhere else I think. twisted.internet.test.test_time? Or twisted.internet.test.test_base (only because, perhaps, it's something of a stretch for an interface test).
  2. What about twisted.internet.test.test_base? That seems like an important part of porting twisted.internet.base...
  3. Some of the process code in twisted.internet.base looks like it won't work on Python 3 - it uses unicode but doesn't import twisted.python.compat.unicode. Perhaps that's fine for now, since porting process support does seem like a fairly separate task. So maybe this ticket is just "port some of twisted.internet.base".
  4. Maybe TestProducer._dontPausePullConsumerTest should have a docstring now, at least documenting the allowed values for methodName.

7

Changed 8 months ago by itamarst

(In [36027]) Address review comments. Refs #6065

8

Changed 8 months ago by itamar

  • keywords review added
  • owner changed from itamar to exarkun
  1. That already had a test for this, so just deleted one I added.
  2. Oops. Added.
  3. I updated the test description to note that it doesn't include process code, and I reverted the changes I made to process code in base.
  4. Added.

Ready for review, I think:  http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/base-py3-6065

9

Changed 8 months ago by exarkun

  • keywords review removed
  • owner changed from exarkun to itamar
  1. The pass in the body of nothing in test_base.py is unneeded. Hooray docstrings.
  2. There's a merge conflict in the howto.

Otherwise looks good. Please merge when these are addressed.

10

Changed 8 months ago by itamarst

  • branch changed from branches/base-py3-6065 to branches/base-py3-6065-2

(In [36077]) Branching to 'base-py3-6065-2'

11

Changed 8 months ago by itamarst

  • status changed from new to closed
  • resolution set to fixed

(In [36081]) Merge base-py3-6065-2.

Author: itamar Review: exarkun Fixes: #6065

Port twisted.internet.base to Python 3.

Note: See TracTickets for help on using tickets.