Ticket #6064 defect new

Opened 8 months ago

Last modified 4 weeks ago

Write tests for `twisted.internet.protocol.FileWrapper`

Reported by: itamar Owned by:
Priority: normal Milestone:
Component: core Keywords: review
Cc: kylerzhang11@… Branch:
Author: Launchpad Bug:

Description

twisted.internet.protocol.FileWrapper has no tests. We should write some, and may as well make them pass on Python 3 while we're t it.

Attachments

6064.patch Download (5.3 KB) - added by kkpattern 4 weeks ago.
Add tests for twisted.internet.protocol.FileWrapper.

Change History

1

follow-up: ↓ 2   Changed 8 months ago by itamar

Alternatively, it could be deprecated and its internal users switched to twisted.test.proto_helpers.StringTransport.

2

in reply to: ↑ 1   Changed 4 weeks ago by kkpattern

Replying to itamar:

Alternatively, it could be deprecated and its internal users switched to twisted.test.proto_helpers.StringTransport.

Hi, since I'm applying for working on Twisted through Google Summer of Code, I think writing tests for twisted.internet.protocol.FileWrapper could be a good opportunity for me to get familiar with developing in Twisted. So I want to work on this ticket as my second patch for Twisted. I hope it's OK.

Changed 4 weeks ago by kkpattern

Add tests for twisted.internet.protocol.FileWrapper.

3

  Changed 4 weeks ago by kkpattern

  • keywords review added
  • cc kylerzhang11@… added
Note: See TracTickets for help on using tickets.