Ticket #6060 enhancement closed fixed

Opened 9 months ago

Last modified 8 months ago

Port twisted.internet.protocol to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/protocol-py3-6060
(diff, github, buildbot, log)
Author: itamarst Launchpad Bug:

Description

twisted.internet.protocol should run on Python 3.

Change History

1

Changed 9 months ago by itamarst

  • branch set to branches/protocol-py3-6060
  • branch_author set to itamarst

(In [35952]) Branching to 'protocol-py3-6060'

2

Changed 9 months ago by itamar

  • owner changed from itamar to exarkun
  • keywords review added

I improved test coverage somewhat, and moved over a couple of tests from twisted.test.test_protocols to a better location (they were otherwise unchanged). I opened a separate ticket (#6064) for FileWrapper test coverage.

 http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/protocol-py3-6060 has been started.

3

Changed 9 months ago by itamar

Oh, and I should note I didn't do tests for the datagram and process classes since they're (somewhat) tested by UDP and process code.

4

Changed 9 months ago by exarkun

  • owner changed from exarkun to itamar
  • keywords review removed

Woo! Tests yay. Thanks.

  1. __future__ imports in twisted.internet.protocol
  2. AdapterTests.test_consumerToProtocol docstring says IConsumer where it means IProtocol
  3. You're also marked as the maintainer of twisted.internet.protocol, in case you wanted to do something about that. :)

That's all. Please merge when these are addressed.

5

Changed 8 months ago by itamarst

  • status changed from new to closed
  • resolution set to fixed

(In [36029]) Merge protocol-py3-6008.

Author: itamar Review: exarkun Fixes: #6060

Port twisted.internet.protocol to Python 3.

Note: See TracTickets for help on using tickets.