Ticket #6059 enhancement closed fixed

Opened 19 months ago

Last modified 19 months ago

Port twisted.names.common to Python 3

Reported by: exarkun Owned by: exarkun
Priority: normal Milestone: Python 3.3 Minimal
Component: names Keywords:
Cc: Branch: branches/dns-common-py3-6059
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

This is needed by twisted.names.client.

Change History

1

Changed 19 months ago by exarkun

  • branch set to branches/dns-common-py3-6059
  • branch_author set to exarkun

(In [36015]) Branching to 'dns-common-py3-6059'

2

Changed 19 months ago by exarkun

  • owner changed from exarkun to itamar
  • keywords review added

Okay, there's some stuff. Pretty straight-forward. This ports twisted.names.error as well, since that ended up not needing much porting and has no dedicated test module of its own. The test coverage here isn't great, but other parts of Twisted Names test suite exercise this code somewhat more, so when those are ported the coverage will improve. I think maybe that's an okay approach for this code.  Build results

3

Changed 19 months ago by itamar

  • owner changed from itamar to exarkun
  • keywords review removed
  1. Two news files.
  2. You should verify in the tests that the result of ResolverBase.query is the result of the underlying function being called.
  3. extractRecords only has very implicit test coverage at best, it seems. At the very least you should open a ticket for that, if it's not needed for the use cases we're covering.

Other than that looks good, please merge.

4

Changed 19 months ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [36039]) Merge dns-common-py3-6059

Author: exarkun Reviewer: itamarst Fixes: #6058 Fixes: #6059

Port twisted.names.error (trivial) and twisted.names.common to Python 3. Also improve some of the test coverage and fix a few structural documentation errors.

Note: See TracTickets for help on using tickets.