Opened 2 years ago

Closed 22 months ago

#6055 enhancement closed fixed (fixed)

Port twisted.internet.gireactor to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: exarkun Branch: branches/gireactor-py3-6055-4
(diff, github, buildbot, log)
Author: itamarst Launchpad Bug:

Description

twisted.internet.gireactor should run on Python 3.

Change History (12)

comment:1 Changed 2 years ago by itamarst

  • Author set to itamarst
  • Branch set to branches/gireactor-py3-6055

(In [35949]) Branching to 'gireactor-py3-6055'

comment:2 Changed 23 months ago by itamarst

  • Branch changed from branches/gireactor-py3-6055 to branches/gireactor-py3-6055-2

(In [36256]) Branching to 'gireactor-py3-6055-2'

comment:3 Changed 23 months ago by itamar

  • Cc exarkun added

Sigh. This evolved into a combination of porting to Python 3, and updating the code to work with the versions of gtk and pygobject in Ubuntu 12.10. I will move latter into separate ticket once #6161 is merged, except in the unlikely event you'd like to review the two combined.

comment:4 Changed 22 months ago by itamarst

  • Branch changed from branches/gireactor-py3-6055-2 to branches/gireactor-py3-6055-3

(In [36430]) Branching to 'gireactor-py3-6055-3'

comment:5 Changed 22 months ago by itamar

  • Keywords review added
  • Owner changed from itamar to exarkun

comment:6 Changed 22 months ago by exarkun

  • Keywords review removed
  • Owner changed from exarkun to itamar
  1. Might it not be more idiomatic, in gireactor.py, to write _pygtkcompatPresent = "gi.pygtkcompat" in theSystemPath?
  2. Do end users really care about changed test behavior in obscure conditions? Maybe they do...

http://buildbot.twistedmatrix.com/builders/python-3.3-tests/builds/275/steps/shell_1/logs/stdio seems like a problem. Perhaps we shouldn't add this test module to the list to run on Python 3 yet, so the rest can continue to run?

comment:7 Changed 22 months ago by itamar

  1. I'll fix that, yeah.
  2. Oops, that's left over from when #6170 was in this branched. Will switch to misc.
  3. That buildbot error is what #6170 fixes...

comment:8 Changed 22 months ago by itamar

Actually, can't use in - see #6198.

comment:9 Changed 22 months ago by itamarst

  • Branch changed from branches/gireactor-py3-6055-3 to branches/gireactor-py3-6055-4

(In [36516]) Branching to 'gireactor-py3-6055-4'

comment:10 Changed 22 months ago by itamar

  • Keywords review added
  • Owner changed from itamar to exarkun

OK, ready for review again. Hopefully buildbot will be happy now.

http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/gireactor-py3-6055-4

comment:11 Changed 22 months ago by exarkun

  • Keywords review removed
  • Owner changed from exarkun to itamar

Hopefully buildbot will be happy now.

eventually it decided to be...

Please merge.

comment:12 Changed 22 months ago by itamarst

  • Resolution set to fixed
  • Status changed from new to closed

(In [36519]) Merge gireactor-py3-6055-4.

Author: itamar
Review: exarkun
Fixes: #6055

Port gireactor to Python 3.

Note: See TracTickets for help on using tickets.