Context Navigation

← Previous Ticket
Next Ticket →

Ticket #6055 enhancement closed fixed

Last modified 7 months ago

Port twisted.internet.gireactor to Python 3

Reported by:	itamar	Owned by:	itamar
Priority:	normal	Milestone:	Python 3.3 Minimal
Component:	core	Keywords:
Cc:	exarkun	Branch:	branches/gireactor-py3-6055-4 (diff, github, buildbot, log)
Author:	itamarst	Launchpad Bug:

Description

twisted.internet.gireactor should run on Python 3.

Change History

1

Changed 9 months ago by itamarst

branch set to branches/gireactor-py3-6055
branch_author set to itamarst

(In [35949]) Branching to 'gireactor-py3-6055'

2

Changed 8 months ago by itamarst

branch changed from branches/gireactor-py3-6055 to branches/gireactor-py3-6055-2

(In [36256]) Branching to 'gireactor-py3-6055-2'

3

Changed 8 months ago by itamar

cc exarkun added

Sigh. This evolved into a combination of porting to Python 3, and updating the code to work with the versions of gtk and pygobject in Ubuntu 12.10. I will move latter into separate ticket once #6161 is merged, except in the unlikely event you'd like to review the two combined.

4

Changed 7 months ago by itamarst

branch changed from branches/gireactor-py3-6055-2 to branches/gireactor-py3-6055-3

(In [36430]) Branching to 'gireactor-py3-6055-3'

5

Changed 7 months ago by itamar

keywords review added
owner changed from itamar to exarkun

Merged forward, requires X to run tests (until #6170 is fixed).

http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/gireactor-py3-6055-3

6

Changed 7 months ago by exarkun

owner changed from exarkun to itamar
keywords review removed

Might it not be more idiomatic, in gireactor.py, to write _pygtkcompatPresent = "gi.pygtkcompat" in theSystemPath?
Do end users really care about changed test behavior in obscure conditions? Maybe they do...

http://buildbot.twistedmatrix.com/builders/python-3.3-tests/builds/275/steps/shell_1/logs/stdio seems like a problem. Perhaps we shouldn't add this test module to the list to run on Python 3 yet, so the rest can continue to run?