Ticket #6051 defect closed fixed

Opened 8 months ago

Last modified 2 months ago

twisted.trial.test.test_tests doesn't follow the coding standard

Reported by: itamar Owned by: wsanchez
Priority: normal Milestone:
Component: trial Keywords: review
Cc: jml Branch:
Author: Launchpad Bug:

Description

twisted.trial.test.test_tests should follow the coding standard. All tests should have docstrings, their name should start with test_, etc..

Attachments

ticket-6051-docs.patch Download (29.2 KB) - added by wirehead 2 months ago.
patch to make twisted/trial/test/test_tests.py comply to standard.

Change History

1

Changed 8 months ago by DefaultCC Plugin

  • cc jml added

2

Changed 3 months ago by weiteng

  • owner set to weiteng

3

Changed 3 months ago by weiteng

  • owner weiteng deleted

4

Changed 2 months ago by wirehead

  • status changed from new to assigned
  • owner set to wirehead

5

Changed 2 months ago by wirehead

Present style dings:

  • Docstrings:
    • I am assuming that all those "See Module Docstrings" are not OK.
    • Some functions are missing docstrings altogether.
  • Naming
    • Some functions named testBlah instead of test_blah

Changed 2 months ago by wirehead

patch to make twisted/trial/test/test_tests.py comply to standard.

6

Changed 2 months ago by wirehead

  • keywords review added; easy removed
  • owner wirehead deleted
  • status changed from assigned to new

the ClassTest in GCMixin seems to be unnecessary and doesn't break anything. Am I right about this?

Should be nothing but formatting and comments otherwise..

7

Changed 2 months ago by wsanchez

Very nice. +1.

8

Changed 2 months ago by wsanchez

  • owner set to wsanchez
  • status changed from new to assigned

9

Changed 2 months ago by wsanchez

  • status changed from assigned to closed
  • resolution set to fixed

(In [37638]) Apply ticket-6051-docs.patch: Add docs to test_tests.

Author: wirehead Reviewer: wsanchez Fixes: #6051

Make twisted/trial/test/test_tests.py comply to standard.

Note: See TracTickets for help on using tickets.