Opened 3 years ago

Closed 14 months ago

#6044 task closed fixed (fixed)

Deprecate `deferredGenerator`

Reported by: exarkun Owned by: tom.prince
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/deprecate-deferredGenerator-6044-4
(diff, github, buildbot, log)
Author: tomprince Launchpad Bug:

Description

twisted.internet.defer.deferredGenerator is like twisted.internet.defer.inlineCallbacks but for Python <= 2.5. Since Twisted no longer supports Python 2.5, there's no reason to continue to offer deferredGenerator (inlineCallbacks is better in every way except for the newer Python requirement).

Change History (11)

comment:1 Changed 2 years ago by tomprince

  • Author set to tomprince
  • Branch set to branches/deprecate-deferredGenerator-6044

(In [37164]) Branching to deprecate-deferredGenerator-6044.

comment:2 Changed 2 years ago by tom.prince

  • Owner set to tom.prince

This depends on #6316 and #5564.

comment:3 Changed 23 months ago by tomprince

  • Branch changed from branches/deprecate-deferredGenerator-6044 to branches/deprecate-deferredGenerator-6044-2

(In [39166]) Branching to deprecate-deferredGenerator-6044-2.

comment:4 Changed 23 months ago by tomprince

  • Branch changed from branches/deprecate-deferredGenerator-6044-2 to branches/deprecate-deferredGenerator-6044-3

(In [39171]) Branching to deprecate-deferredGenerator-6044-3.

comment:5 Changed 23 months ago by tom.prince

I split off the removal of existing uses to #6626. Once that is merged, this is ready for review.

comment:6 Changed 18 months ago by tomprince

  • Branch changed from branches/deprecate-deferredGenerator-6044-3 to branches/deprecate-deferredGenerator-6044-4

(In [40920]) Branching to deprecate-deferredGenerator-6044-4.

comment:7 Changed 18 months ago by tomprince

(In [40922]) Branching to deprecate-deferredGenerator-6044-4.

comment:8 Changed 18 months ago by tom.prince

  • Keywords review added
  • Owner tom.prince deleted

comment:9 Changed 17 months ago by glyph

  • Keywords review removed
  • Owner set to tom.prince

Basically; cool. Please make twistedchecker happy though. Also, any reason @deprecated didn't work for the __init__ thing? Is it the stacklevel thing? Perhaps there should be a ticket.

Thanks!

comment:10 Changed 14 months ago by tom.prince

#7147 is a ticket about the deprecation of waitForDeferred.

comment:11 Changed 14 months ago by tomprince

  • Resolution set to fixed
  • Status changed from new to closed

(In [42242]) Merge deprecate-deferredGenerator-6044-4: Deprecate deferredGenerator.

Author: tom.prince
Reviewer: glyph
Fixes: #6044

twisted.internet.defer.deferredGenerator is like
twisted.internet.defer.inlineCallbacks but for Python <= 2.5. Since
Twisted no longer supports Python 2.5, there's no reason to continue
to offer deferredGenerator (inlineCallbacks is better in every way
except for the newer Python requirement).

Note: See TracTickets for help on using tickets.