Opened 5 years ago

Closed 3 years ago

#6044 task closed fixed (fixed)

Deprecate `deferredGenerator`

Reported by: Jean-Paul Calderone Owned by: Tom Prince
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/deprecate-deferredGenerator-6044-4
branch-diff, diff-cov, branch-cov, buildbot
Author: tomprince

Description

twisted.internet.defer.deferredGenerator is like twisted.internet.defer.inlineCallbacks but for Python <= 2.5. Since Twisted no longer supports Python 2.5, there's no reason to continue to offer deferredGenerator (inlineCallbacks is better in every way except for the newer Python requirement).

Change History (11)

comment:1 Changed 5 years ago by Tom Prince

Author: tomprince
Branch: branches/deprecate-deferredGenerator-6044

(In [37164]) Branching to deprecate-deferredGenerator-6044.

comment:2 Changed 4 years ago by Tom Prince

Owner: set to Tom Prince

This depends on #6316 and #5564.

comment:3 Changed 4 years ago by Tom Prince

Branch: branches/deprecate-deferredGenerator-6044branches/deprecate-deferredGenerator-6044-2

(In [39166]) Branching to deprecate-deferredGenerator-6044-2.

comment:4 Changed 4 years ago by Tom Prince

Branch: branches/deprecate-deferredGenerator-6044-2branches/deprecate-deferredGenerator-6044-3

(In [39171]) Branching to deprecate-deferredGenerator-6044-3.

comment:5 Changed 4 years ago by Tom Prince

I split off the removal of existing uses to #6626. Once that is merged, this is ready for review.

comment:6 Changed 4 years ago by Tom Prince

Branch: branches/deprecate-deferredGenerator-6044-3branches/deprecate-deferredGenerator-6044-4

(In [40920]) Branching to deprecate-deferredGenerator-6044-4.

comment:7 Changed 4 years ago by Tom Prince

(In [40922]) Branching to deprecate-deferredGenerator-6044-4.

comment:8 Changed 4 years ago by Tom Prince

Keywords: review added
Owner: Tom Prince deleted

comment:9 Changed 4 years ago by Glyph

Keywords: review removed
Owner: set to Tom Prince

Basically; cool. Please make twistedchecker happy though. Also, any reason @deprecated didn't work for the __init__ thing? Is it the stacklevel thing? Perhaps there should be a ticket.

Thanks!

comment:10 Changed 3 years ago by Tom Prince

#7147 is a ticket about the deprecation of waitForDeferred.

comment:11 Changed 3 years ago by Tom Prince

Resolution: fixed
Status: newclosed

(In [42242]) Merge deprecate-deferredGenerator-6044-4: Deprecate deferredGenerator.

Author: tom.prince Reviewer: glyph Fixes: #6044

twisted.internet.defer.deferredGenerator is like twisted.internet.defer.inlineCallbacks but for Python <= 2.5. Since Twisted no longer supports Python 2.5, there's no reason to continue to offer deferredGenerator (inlineCallbacks is better in every way except for the newer Python requirement).

Note: See TracTickets for help on using tickets.