Opened 2 years ago

Closed 2 years ago

#6041 enhancement closed fixed (fixed)

twisted.python.test.module_helpers import twisted.python.modules

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/modulehelpers-py3-6041
(diff, github, buildbot, log)
Author: itamarst Launchpad Bug:

Description

Due to porting dependencies (twisted.python.modules hasn't yet been ported to Python 3), it would be useful for twisted.python.test.module_helpers to not import modules. The one function that depends on it is in any case only used in twisted.test.test_modules and can be easily moved.

Change History (4)

comment:1 Changed 2 years ago by itamarst

  • Author set to itamarst
  • Branch set to branches/modulehelpers-py3-6041

(In [35896]) Branching to 'modulehelpers-py3-6041'

comment:2 Changed 2 years ago by itamar

  • Keywords review added
  • Owner set to exarkun

comment:3 Changed 2 years ago by exarkun

  • Keywords review removed
  • Owner changed from exarkun to itamar

Thanks. Looks good. Please merge.

comment:4 Changed 2 years ago by itamarst

  • Resolution set to fixed
  • Status changed from new to closed

(In [35902]) Merge modulehelpers-py3-6041.

Author: itamar
Review: exarkun
Fixes: #6041

twisted.python.test.modules_helpers now works on Python 3.

Note: See TracTickets for help on using tickets.