Opened 4 years ago

Closed 4 years ago

#6041 enhancement closed fixed (fixed)

twisted.python.test.module_helpers import twisted.python.modules

Reported by: Itamar Turner-Trauring Owned by: Itamar Turner-Trauring
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/modulehelpers-py3-6041
branch-diff, diff-cov, branch-cov, buildbot
Author: itamarst

Description

Due to porting dependencies (twisted.python.modules hasn't yet been ported to Python 3), it would be useful for twisted.python.test.module_helpers to not import modules. The one function that depends on it is in any case only used in twisted.test.test_modules and can be easily moved.

Change History (4)

comment:1 Changed 4 years ago by itamarst

Author: itamarst
Branch: branches/modulehelpers-py3-6041

(In [35896]) Branching to 'modulehelpers-py3-6041'

comment:2 Changed 4 years ago by Itamar Turner-Trauring

Keywords: review added
Owner: set to Jean-Paul Calderone

comment:3 Changed 4 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from Jean-Paul Calderone to Itamar Turner-Trauring

Thanks. Looks good. Please merge.

comment:4 Changed 4 years ago by itamarst

Resolution: fixed
Status: newclosed

(In [35902]) Merge modulehelpers-py3-6041.

Author: itamar Review: exarkun Fixes: #6041

twisted.python.test.modules_helpers now works on Python 3.

Note: See TracTickets for help on using tickets.