Opened 23 months ago

Last modified 23 months ago

#6038 defect new

twisted.trial.test.test_deferred is badly implemented

Reported by: itamar Owned by:
Priority: normal Milestone:
Component: trial Keywords:
Cc: jml Branch:
Author: Launchpad Bug:

Description

twisted.trial.test.test_deferred has some issues (as reported by JP):

  1. runTest is part of the TestCase API, it's a bad idea to re-use it for something else.
  2. Other trial tests use the loader to get something runnable instead of doing a manual loading step like getTest is doing.
  3. Some of these tests are slow, waiting for a 0.1s timeout before proceeding.
  4. No docs anywhere.

Change History (2)

comment:1 Changed 23 months ago by DefaultCC Plugin

  • Cc jml added

comment:2 Changed 23 months ago by itamar

Also, we shouldn't need to delete TestTester. Instead, it should probably be in a separate module that isn't loaded by trial; twisted.trial.test.detests would be the obvious choice.

Note: See TracTickets for help on using tickets.