Ticket #6023 enhancement closed fixed

Opened 9 months ago

Last modified 9 months ago

Port twisted.internet.test.test_udp and test_udp_internals to Python 3

Reported by: itamar Owned by: itamar
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/testudp-py3-6023
(diff, github, buildbot, log)
Author: itamarst Launchpad Bug:

Description

Unfortunately twisted.internet.test.test_udp and test_udp_internals don't provide enough coverage to prove UDP works (that'll need to wait for twisted.test.test_udp which depends on TestCase), but they should be ported.

Change History

1

Changed 9 months ago by itamarst

  • branch set to branches/testudp-py3-6023
  • branch_author set to itamarst

(In [35826]) Branching to 'testudp-py3-6023'

2

Changed 9 months ago by itamar

  • owner set to exarkun
  • keywords review added

Start build:

 http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/testudp-py3-6023

3

Changed 9 months ago by exarkun

  • owner changed from exarkun to itamar
  • keywords review removed
  1. __future__ imports missing here and there
  2. Would be nice to have a ticket link in the comment in test_unregisterProducerAfterDisconnect in connectionmixins.py

Otherwise looks good, merge when the above are addressed.

4

Changed 9 months ago by itamarst

  • status changed from new to closed
  • resolution set to fixed

(In [35838]) Merge testudp-py3-6023.

Author: itamar Review: exarkun Fixes: #6023

Port twisted.internet.test.test_udp and test_udp_internals to Python 3.

Note: See TracTickets for help on using tickets.