Opened 2 years ago

Closed 2 years ago

#6019 enhancement closed fixed (fixed)

Merge twisted.trial._utilpy3 back into twisted.trial.util

Reported by: itamar Owned by: exarkun
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/merge-trial-util-utilpy3-6019
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

twisted.trial._utilpy3 is no longer necessary, and can be merged back into trial (once #6009 is merged).

Change History (7)

comment:1 Changed 2 years ago by exarkun

  • Owner set to exarkun
  • Status changed from new to assigned

comment:2 Changed 2 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/merge-trial-util-utilpy3-6019

(In [35879]) Branching to 'merge-trial-util-utilpy3-6019'

comment:3 Changed 2 years ago by exarkun

(In [35880]) Move utilpy3 code into util; move test_utilpy3 code into test_util; subclass SynchronousTestCase instead of stdlib TestCase.

refs #6019

comment:4 Changed 2 years ago by exarkun

(In [35882]) Update random code that was using twisted.trial._utilpy3

refs #6019

comment:5 Changed 2 years ago by exarkun

  • Keywords review added
  • Owner changed from exarkun to itamar
  • Status changed from assigned to new

comment:6 Changed 2 years ago by itamar

  • Keywords review removed
  • Owner changed from itamar to exarkun

Looks good, merge after one fix: you forgot to remove twisted.trial.test.test_utilpy3 from admin/_twistedpython3.py.

comment:7 Changed 2 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [35909]) Merge merge-trial-util-utilpy3-6019

Author: exarkun
Reviewer: itamar
Fixes: #6019

Merge the temporary porting aid twisted.trial._utilpy3 back into twisted.trial.util now that
all of twisted.trial.util has been ported to Python 3.

Note: See TracTickets for help on using tickets.