Ticket #6019 enhancement closed fixed

Opened 9 months ago

Last modified 9 months ago

Merge twisted.trial._utilpy3 back into twisted.trial.util

Reported by: itamar Owned by: exarkun
Priority: normal Milestone: Python 3.3 Minimal
Component: core Keywords:
Cc: Branch: branches/merge-trial-util-utilpy3-6019
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

twisted.trial._utilpy3 is no longer necessary, and can be merged back into trial (once #6009 is merged).

Change History

1

Changed 9 months ago by exarkun

  • status changed from new to assigned
  • owner set to exarkun

2

Changed 9 months ago by exarkun

  • branch set to branches/merge-trial-util-utilpy3-6019
  • branch_author set to exarkun

(In [35879]) Branching to 'merge-trial-util-utilpy3-6019'

3

Changed 9 months ago by exarkun

(In [35880]) Move utilpy3 code into util; move test_utilpy3 code into test_util; subclass SynchronousTestCase instead of stdlib TestCase.

refs #6019

4

Changed 9 months ago by exarkun

(In [35882]) Update random code that was using twisted.trial._utilpy3

refs #6019

5

Changed 9 months ago by exarkun

  • owner changed from exarkun to itamar
  • status changed from assigned to new
  • keywords review added

Okay:  http://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/merge-trial-util-utilpy3-6019

6

Changed 9 months ago by itamar

  • keywords review removed
  • owner changed from itamar to exarkun

Looks good, merge after one fix: you forgot to remove twisted.trial.test.test_utilpy3 from admin/_twistedpython3.py.

7

Changed 9 months ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [35909]) Merge merge-trial-util-utilpy3-6019

Author: exarkun Reviewer: itamar Fixes: #6019

Merge the temporary porting aid twisted.trial._utilpy3 back into twisted.trial.util now that all of twisted.trial.util has been ported to Python 3.

Note: See TracTickets for help on using tickets.